Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC.Sty: Javascript files complaint is not being checked correctly #108

Open
rjdmartins opened this issue Oct 24, 2022 · 1 comment
Open

Comments

@rjdmartins
Copy link

rjdmartins commented Oct 24, 2022

We have done an online assessment to WORSICA, and we noticed this:

  • JavaScript files are not fully compliant with stylelint standard

This is the command that does the check:

(
cd github.com/WORSICA/eosc-worsica-frontend &&
npx stylelint **/*.vue
)

We do not understand why is it checking .vue files, since WORSICA has .js files.
Also, it should not be a desired requirement, since not all projects do have Javascript/VUE files.
Our suggestion to fix this is by verifying before if repository has .vue files or .js files in order to do that check.

@rjdmartins
Copy link
Author

rjdmartins commented Nov 16, 2022

As I mentioned, this check must be applied if the repository has Javascript files.

Jenkins output below for eosc-worsica-frontend:

Link to Jenkins: https://jenkins.eosc-synergy.eu/job/eosc-synergy-org/job/eosc-worsica-frontend.assess.sqaaas/job/main/10/execution/node/124/log/?consoleFull

docker-compose -f .sqa/docker-compose.yml --project-directory /jenkins/workspace/sica-frontend.assess.sqaaas_main/ exec -T qc.sty_skanky-maroon-chihuahua /usr/bin/env sh .sqa/script.cheeky-peach-cheetah.sh
Error: ENOENT: no such file or directory, open '/sqaaas-build/github.com/WORSICA/eosc-worsica-frontend/root/.stylelintrc.json'
npm notice
npm notice New major version of npm available! 8.19.2 -> 9.1.1
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.1.1
npm notice Run npm install -g [email protected] to update!
npm notice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant