Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable passing attributes and properties to the drawtools and generated map #1562

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

A-Behairi
Copy link
Collaborator

@A-Behairi A-Behairi commented Feb 25, 2025

Implemented changes

this PR restructures the expected schema passed to the SpatialEditor to include properties and attributes of the drawtools to be passed under options.drawtools. In case there's no for property passed the editor creates an eox-map element which can be configured now using options.map

Screenshots/Videos

Checklist before requesting a review

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 3628c38
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/67bdb04cc1f3d10008f73b2a
😎 Deploy Preview https://deploy-preview-1562--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@silvester-pari silvester-pari merged commit a47a665 into main Feb 25, 2025
8 checks passed
@silvester-pari silvester-pari deleted the jsonform/fix/drawtools-api branch February 25, 2025 14:46
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants