[WIP]: Add filenames to cpl.input_data_list, more error messaging, set drv_restart_pointer default to none unless needed #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st file to check for file existence, fixing ESCOMP#526
… allow continue_run as well), add it as a file that will be put into cpl.input_data_list for existence checking, fixing ESCOMP#525
ekluzek
added
enhancement
…e drv_restart_pointer is set in that case, also move it and rundir to the default_settings group so won't be output
…utdata named none -- but when UNSET is used it doesn't add it to cpl.input_data_list and so works
|
#532 brings in some additional nice changes beyond what is in here. And after that comes in I'll update to it, and likely change a few things here that won't be needed anymore. |
|
billsacks
reviewed
Jan 28, 2025
billsacks
reviewed
Jan 28, 2025
| @@ -320,7 +320,7 @@ def _create_drv_namelists(case, infile, confdir, nmlgen, files): | |||
| # Write namelist file drv_in and initial input dataset list. | |||
| # -------------------------------- | |||
| namelist_file = os.path.join(confdir, "drv_in") | |||
| drv_namelist_groups = ["papi_inparm", "prof_inparm", "debug_inparm"] | |||
| drv_namelist_groups = ["DRIVER_attributes", "MED_attributes", "ALLCOMP_attributes", "ROF_attributes", "WAV_attributes"] | |||
There was a problem hiding this comment.
Can you explain this change - why you removed the old set and how you chose this new set of groups?
Comment on lines
+21
to
+39
| <entry id="rundir" modify_via_xml="RUNDIR"> | ||
| <type>char</type> | ||
| <category>nuopc</category> | ||
| <!-- NOTE: This won't be output only used as an attribute in this file --> | ||
| <group>default_settings</group> | ||
| <values> | ||
| <value>$RUNDIR</value> | ||
| </values> | ||
| </entry> | ||
|
|
||
| <entry id="continue_run" modify_via_xml="CONTINUE_RUN"> | ||
| <type>logical</type> | ||
| <category>nuopc</category> | ||
| <!-- NOTE: This won't be output only used as an attribute in this file --> | ||
| <group>default_settings</group> | ||
| <values> | ||
| <value>$CONTINUE_RUN</value> | ||
| </values> | ||
| </entry> |
There was a problem hiding this comment.
I'm not super-familiar with this, but I'm thinking that you can accomplish this by setting rundir and continue_run in the config settings in buildnml, similarly to what's currently done for many other variables in _create_drv_namelists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Correct the input groups with filenames to be added to cpl.input_data_list. Add more error messaging to the log files around rpointer errors. Set the drv_restart_pointer by default to none, unless it's needed, and make it a relative path to RUNDIR so will be added to cpl.input_data_list and checked that it exists.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Fixes #524
Fixes #525
Fixes #526
Are changes expected to change answers? bfb
Any User Interface Changes (namelist or namelist defaults changes)? yes
drv_restart_pointer gets set to "none" except for cases that need it like branch
Testing performed.
currently only tested with ctsm5.3.020 which uses: ccs_config_cesm1.0.16, and cime from ESMCI/cime#4739
and for a simple case with a startup and branch type
will do more testing, and will update the PR and report about what's done.
Plan to run aux_clm testlist as well as aux_cmeps.