Skip to content

Race condition #120

Open
Open
@crymall

Description

@crymall

There is a race condition causing this code (in DFP.ts) to run even when the slot does end up having a contentUrl:

 if (!slot.getContentUrl()) {
            this.ad.isEmpty = true;

            dispatchEvent(
              Number(this.id.substring(this.id.length, this.id.length - 1)),
              LOG_LEVELS.WARN,
              'DFP Network',
              'Ad sizes missing. Bypassing ad.',
            );
            resolve();
}

This causes ad lifecycle events intended for after the ad renders to think that the ad is empty when it is not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions