Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SBUS serial input #1468

Open
wimalopaan opened this issue Jan 18, 2022 · 2 comments
Open

Fix SBUS serial input #1468

wimalopaan opened this issue Jan 18, 2022 · 2 comments

Comments

@wimalopaan
Copy link
Contributor

SBUS signals with period <=8ms are not correctly recognized.

The SBUS input processor uses a sample interval of 5ms, therefore it can only detect stream-pauses > 5ms. If SBUS period is < 8ms, the pause is < 5ms and then the SBUS input processor fails to detect this stream pause. This leads to trainer lost.

@wimalopaan
Copy link
Contributor Author

Channel0: SBUS frame of FS-A8S with about 4ms pause and the cycles the original processSbusInput() gets called. Should be every 5ms, but it is about 2,3ms to 4,7ms:
SBUS_FS-A8S_processSbusInput_5ms
Demonstrates that the pause detection will not work: the pulses on channel1 shows the call timepoint.

Channel0: SBus frame of FS-A8S with about 4ms pause and new conversion times (channel 1):
SBUS_FS-A8S_convert_1ms

Channel0: SBus frame of FS-iA10B with about 4,7ms pause and new conversion times (channel 1):
SBUS_FS-iA10B_convert_1ms
(original decoding worked with glitches every 30s)

Channel0: SBus frame of R168 with about 6ms pause and new conversion times (channel 1):
SBUS_R168_convert_1ms
(original decoding worked)

@wimalopaan
Copy link
Contributor Author

Should be fixed in #1462

@pfeerick pfeerick linked a pull request Jan 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant