Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All builtin specifications now correctly recognize boost parameter. #82

Merged
merged 2 commits into from
Aug 9, 2024
Merged

All builtin specifications now correctly recognize boost parameter. #82

merged 2 commits into from
Aug 9, 2024

Conversation

ondrej-sladky-eligo
Copy link
Contributor

Hello!

I've found out that some of the builtin specifications either don't recognize boost argument and some do, but set it incorrectly. In particular:

  • AllowPrimer (as discussed in Question: No boost for AllowPrimer #71 ), AvoidBlastMatches and SequenceLengthBounds did not accept the boost argument (the omitting of boost in SequenceLengthBounds might have been intentional, but added it for consistency).
  • AvoidHeterodimenzation accepted the parameter, but did not set it.
  • UniquifyAllKmers accepted the parameter, but set it to 1.0 regardless.

This PR fixes the aforementioned issues.
And possibly closes #71 .

Best,
Ondrej

@veghp veghp changed the base branch from master to dev August 9, 2024 13:02
@veghp veghp merged commit c4d3ec1 into Edinburgh-Genome-Foundry:dev Aug 9, 2024
@veghp
Copy link
Member

veghp commented Aug 9, 2024

Thank you -- I'll make a release soon, addressing a few other issues as well. Probably at the end of the month only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: No boost for AllowPrimer
2 participants
@ondrej-sladky-eligo @veghp