CircleCI cleanup and bugfixes (#36)

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* [CircleCI] Fix coding standards

* fix

* fix

Co-authored-by: CircleCI <[email protected]>

Author: Ekman

.circleci/config.yml

@@ -4,6 +4,7 @@ orbs:
   composer: stockfiller/[email protected]
   php-cs-fixer: stockfiller/[email protected]
   phpunit: stockfiller/[email protected]
+  php-coveralls: nekman/[email protected]
 
 executors:
   php74:
@@ -15,16 +16,6 @@ executors:
       - image: php:8.0-alpine
     resource_class: small
 
-commands:
-  install_xdebug:
-    steps:
-      - run:
-          name: Install PCOV and Git
-          command: |-
-            apk add --update --no-cache ${PHPIZE_DEPS} git
-            pecl install pcov-1.0.6
-            docker-php-ext-enable pcov
-
 workflows:
   master:
     jobs:
@@ -47,6 +38,7 @@ workflows:
           executor: php74
           rules: "@PSR2"
           pre-steps:
+            - run: apk add --update --no-cache git openssh-client
             - composer/install_bin
           filters: &branch-filters
             branches:
@@ -55,12 +47,14 @@ workflows:
           <<: *unit-tests
           flags: --coverage-clover coverage/clover.xml
           pre-steps:
-            - install_xdebug
+            - run: |-
+                apk add --update --no-cache ${PHPIZE_DEPS} git
+                pecl install pcov-1.0.6
+                docker-php-ext-enable pcov
             - composer/install_bin
           post-steps:
-            - run: php vendor/bin/php-coveralls --verbose
-            - store_artifacts:
-                path: coverage/clover.xml
+            - php-coveralls/upload:
+                clover-path: coverage/clover.xml
           filters: *branch-filters
           requires:
             - coding-standards

README.md

@@ -1,6 +1,6 @@
 # Luhn Algorithm
 
-[![Build Status](https://circleci.com/github/Ekman/luhn-algorithm.svg?style=shield)](https://app.circleci.com/pipelines/github/Ekman)
+[![Build Status](https://circleci.com/gh/Ekman/luhn-algorithm.svg?style=svg)](https://app.circleci.com/pipelines/github/Ekman/luhn-algorithm)
 [![Coverage Status](https://coveralls.io/repos/github/Ekman/luhn-algorithm/badge.svg?branch=master)](https://coveralls.io/github/Ekman/luhn-algorithm?branch=master)
 
 This is a zero dependency implementation of the Luhn Algorithm for PHP 7.0 and above. The Luhn Algorithm is used to validate things like credit cards and national identification numbers. More information on the algorithm can be found at [Wikipedia](http://en.wikipedia.org/wiki/Luhn_algorithm).

src/Number.php

@@ -27,6 +27,7 @@
 
 namespace Nekman\LuhnAlgorithm;
 
+use Nekman\LuhnAlgorithm\Contract\LuhnAlgorithmExceptionInterface;
 use Nekman\LuhnAlgorithm\Contract\NumberInterface;
 use Nekman\LuhnAlgorithm\Exceptions\ArgumentIsNotNumericException;
 use function Nekman\LuhnAlgorithm\Functions\string_is_numeric;
@@ -59,6 +60,7 @@ public function __construct(string $number, int $checkDigit = null)
      * Create a new number from an input that contains the check digit already
      * @param string $input The input that contains the check digit already.
      * @throws ArgumentIsNotNumericException If the input does not consist entirely of numbers.
+     * @throws LuhnAlgorithmExceptionInterface
      * @return self
      *
      */