Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue being used as a nested addon #3

Open
nmcclay opened this issue Jul 14, 2016 · 3 comments · May be fixed by #20
Open

Issue being used as a nested addon #3

nmcclay opened this issue Jul 14, 2016 · 3 comments · May be fixed by #20

Comments

@nmcclay
Copy link

nmcclay commented Jul 14, 2016 

app.import is not a function
TypeError: app.import is not a function
    at Class.module.exports.included (/Users/nmcclay/git/light-table/node_modules/ember-light-table/node_modules/ember-element-resize-detector/index.js:20:17)
    at /Users/nmcclay/git/light-table/node_modules/ember-cli/lib/models/addon.js:244:32

I encountered this issue trying to upgrade ember-light-table and noticed this problem.

    if (!process.env.EMBER_CLI_FASTBOOT) {
      app.import('vendor/element-resize-detector/element-resize-detector.js');
    }
@nmcclay
Copy link
Author

nmcclay commented Jul 14, 2016

Able to reproduce with ember 2.6 and a new addon project.

@nmcclay
Copy link
Author

nmcclay commented Jul 14, 2016

This issue seems directly related to this discussion about nested addons: ember-cli/ember-cli#3718

Moving ember-light-table to a peerDependency seemed to resolve this issue... so I'm moving on.

@GCorbel
Copy link

GCorbel commented Aug 6, 2016

@nmcclay I have the same issue but I'm contributing for this addon. I cannot add ember-light-table as peerDependency. Is there a solution?

@Gaurav0 Gaurav0 linked a pull request Jan 23, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for engines Gaurav0/ember-element-resize-detector
2 participants
@nmcclay @GCorbel