Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambient sounds continue during end screen #56

Open
Trainzack opened this issue Jun 28, 2023 · 3 comments
Open

Ambient sounds continue during end screen #56

Trainzack opened this issue Jun 28, 2023 · 3 comments
Labels
C-Annoying Annoying issue that doesn't impact gameplay Feature Request Look and Feel Issues that affect the look and feel of the game.

Comments

@Trainzack
Copy link
Collaborator

It feels wrong to have gully's birdsong play the same time the ending music does.

@Trainzack Trainzack added C-Annoying Annoying issue that doesn't impact gameplay Feature Request Look and Feel Issues that affect the look and feel of the game. labels Jun 28, 2023
@RoyAwesome
Copy link
Contributor

We probably need to put these into a sound class, and then mute the sound class at the end of the match.

@Trainzack
Copy link
Collaborator Author

Trainzack commented Jun 28, 2023

I guess the real question is, do we want any other sounds during the end game? Like if a tank explodes, are we cool with that being silent?

Because if we are, we can probably do something more broad and mute all the sounds other than music.

@RoyAwesome
Copy link
Contributor

So, technically, we can do whatever we want here. We need to define what soundclasses should play during the end screen and which don't.

I currently have things set to "Turn Off" when we go into the endgame screen, so nothing should die, take damage, or explode. I don't think they would generate sounds. Though, if we had like an "End Game Sequence" where the game locks, and all the cameras zoom over to the CV and we witness a cool explosion effect... we'd want that sound to play.

Perhaps the base course of action here is to tag certain sound classes as "This Plays During Endgame" and be mindful of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Annoying Annoying issue that doesn't impact gameplay Feature Request Look and Feel Issues that affect the look and feel of the game.
Projects
None yet
Development

No branches or pull requests

2 participants