Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a shared mojmap codebase for simple shared NMS code #2405

Open
me4502 opened this issue Oct 9, 2023 · 0 comments
Open

Use a shared mojmap codebase for simple shared NMS code #2405

me4502 opened this issue Oct 9, 2023 · 0 comments
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:tech-debt Task for cleaning up tech debt that has accumulated in the code base

Comments

@me4502
Copy link
Member

me4502 commented Oct 9, 2023

The Problem

Currently we have large amounts of NMS code that either could be shared or is shared, but it's duplicated per platform (and per adapter in the case of Paper).

A Solution

Having a "shared" NMS codebase that is based off an "as clean as possible" mojmap base would allow us to share some code here, significantly reducing duplication and maintenance burden of some parts of code.

Would also likely reduce the size of the Bukkit jar as there'd be less duplication between adapters.

Alternatives

No response

Anything Else?

No response

@me4502 me4502 added status:pending Pending acceptance or closure. type:tech-debt Task for cleaning up tech debt that has accumulated in the code base status:accepted Will be fixed / added to WorldEdit, eventually and removed status:pending Pending acceptance or closure. labels Oct 9, 2023
@octylFractal octylFractal added this to the 7.3.2 milestone May 10, 2024
@me4502 me4502 modified the milestones: 7.3.2, 7.3.3 May 21, 2024
@me4502 me4502 modified the milestones: 7.3.3, 7.3.4 Jun 5, 2024
@octylFractal octylFractal removed this from the 7.3.4 milestone Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:tech-debt Task for cleaning up tech debt that has accumulated in the code base
Projects
None yet
Development

No branches or pull requests

2 participants