Mace smash attack AoE knockback not handled #2190
Labels
status:pending
Pending acceptance or closure.
status:upstream
This issue should be handled upstream from WorldGuard.
type:bug
Incorrect behavior, not working as intended
WorldEdit Version
7.3.10
WorldGuard Version
7.0.13
Platform Version
Paper version 1.21.4-204-main@3d13b11
Confirmations
Bug Description
Hitting a mob with a mace and causing a smash attack (falling from >1.5 blocks before hitting) in a region that has
pvp: deny
causes an AoE knockback effect that knocks other entities as well. This results in the ability of players to knock others out of a region by indirectly hitting other mobs with this attack. (assuming animal / mob harm is allowed to land the attack)Even with animal harm denied it's still possible to do this with mobs.
Expected Behavior
The indirect knockback resulting from the smash attack AoE being denied.
Reproduction Steps
pvp: deny
Result the other player gets sent flying away
Optional WorldGuard-Report
No response
Anything Else?
Fixing this issue most likely requires Paper and Spigot calling
EntityKnockbackByEntityEvent
on other entities affected by the smash attack AoE. This does not yet happen, however I've opened an issue with both to see if that were possible.If I understand correctly since Paper hardforked they are not pulling changes from Spigot, hence two reports.
Paper issue
Spigot issue
I am not sure what changes would be required in WG for this to be protected properly. My assumptions would be either include this behaviour under the pvp flag or create a flag specifically for knockback.
There is also
EntityAttemptSmashAttackEvent
available on Paper that could be used to deny using smash attacks specifically. Adding a flag for that is also what I did in order to overcome the issue. (and tried submitting a PR to WG extra flags)Relevant discussion on the discord server: https://discordapp.com/channels/80853743897149440/470410381597343753/1282704841226850365
The text was updated successfully, but these errors were encountered: