Allow set flags to be manipulate with add and sub keywords
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkArc
force-pushed
the
feature/modifiable-set-flags
branch
from
b574703 to
a453f7e
Compare
This adds support for updating an existing region, so that if you have a long list of items in a set flag, such as `deny-spawn` you can add or remove items, rather than overwrite. Example: ``` /rg flag test deny-spawn add creeper /rg flag test deny-spawn remove zombie ```
DarkArc
force-pushed
the
feature/modifiable-set-flags
branch
from
a453f7e to
c95f52a
Compare
|
Think I would rather have a set syntax like Also this should probably apply to MapFlag as well. Maybe we should abstract out AbstractCollectionFlag type? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for updating an existing region, so that if you have a long list of items in a set flag, such as
deny-spawnyou can add or remove items, rather than overwrite.