Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading scrim always hidden if list is empty #10120

Open
2 of 6 tasks
nwhittaker opened this issue Aug 20, 2024 · 6 comments
Open
2 of 6 tasks

Loading scrim always hidden if list is empty #10120

nwhittaker opened this issue Aug 20, 2024 · 6 comments
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library

Comments

@nwhittaker
Copy link
Contributor

nwhittaker commented Aug 20, 2024

Check existing issues

Actual Behavior

Given a <calcite-list loading /> element with a non-zero height and no children, the loading scrim is not visible.

Screenshot 2024-08-20 at 4 00 21 PM

Expected Behavior

The loading scrim is fully or partially visible depending on how much height the consumer has given the list. In other words, if the list is a scrolling container, the scrim appears centered in the container regardless of how many rows there may be, if any.

Screenshot 2024-08-20 at 4 00 13 PM

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/JjQLXJg

Reproduction Steps

  1. Visit the sample and see the loading scrim is not visible.

Reproduction Version

2.11.1

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

The desire is to be able to use the loading state when initially populating an expensive list.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@nwhittaker nwhittaker added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 20, 2024
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 20, 2024
@driskull
Copy link
Member

The list component is currently displayed as block by default. If we were to change it to flex that would be a visual breaking change.

@nwhittaker
Copy link
Contributor Author

The list component is currently displayed as block by default. If we were to change it to flex that would be a visual breaking change.

Agreed. If the issue can be fixed without changing the list's display, that'd be ideal.

@driskull
Copy link
Member

Yeah, I'm not apposed to changing to flex. We'll just have to note it as a breaking change.

@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Sep 3, 2024
@geospatialem
Copy link
Member

cc #5162

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 3, 2024
@ashetland
Copy link
Contributor

@geospatialem We're removing the design label from this. We agree the long term story here is improvements related to #5162, but that effort shouldn't prevent moving forward with @driskull's fix in the meantime.

@ashetland ashetland removed the design Issues that need design consultation prior to development. label Nov 14, 2024
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 18, 2024
@geospatialem
Copy link
Member

Work towards a min-height for the fix.

@DitwanP DitwanP added this to the 2025-07-29 - 3.3.0 Jul Release milestone Jan 3, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

5 participants