Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to visually determine if focused action is active #10408

Closed
2 of 6 tasks
nwhittaker opened this issue Sep 26, 2024 · 2 comments
Closed
2 of 6 tasks

Difficult to visually determine if focused action is active #10408

nwhittaker opened this issue Sep 26, 2024 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

When an action has focus, it is difficult to tell if the action is active.

Inactive Active
Screenshot 2024-09-26 at 4 00 00 PM Screenshot 2024-09-26 at 4 01 23 PM
Screenshot 2024-09-26 at 4 04 43 PM Screenshot 2024-09-26 at 4 04 52 PM

Expected Behavior

The action's background is the same as when it's unfocused and unhovered. The background color of the inactive action is still set to --calcite-action-background-color-hover when hovered.

Inactive Active
Screenshot 2024-09-26 at 4 10 05 PM Screenshot 2024-09-26 at 4 01 23 PM
Screenshot 2024-09-26 at 4 10 21 PM Screenshot 2024-09-26 at 4 04 52 PM

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/RwXPRVB

Reproduction Steps

  1. Visit the repro.
  2. Move the pointer over/out the action and notice it responds with hover styles.
  3. Click the action to focus and enable its active state.
  4. Click the action again to disable its active state.
  5. Move the pointer over/out the action and notice the background color remains. This makes it difficult to tell if the action is really no longer active. Was instead expecting the hover styles from step 1 to be restored.

Reproduction Version

2.12.2

Relevant Info

An accessibility concern is whether the active styling offers enough contrast. I was considering that out-of-scope and perhaps more appropriate for #5003 anyway.

Should reconsider if the focus style should even get a background change in cases where its focus ring is visible. Of course the user can shift focus, but this is a less discoverable remediation, and it also adds effort to using the action. If focus and hover styles did not share a background color, then moving the pointer off the action would be a more discoverable remediation.

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

Looking for a workaround, --calcite-action-background-color-hover exists, however what really would be needed is a way to set the hover and focus colors separately.

Usability is mostly impacted as it is not immediately clear if an action is really inactive, or not.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@nwhittaker nwhittaker added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 26, 2024
@nwhittaker nwhittaker changed the title Visually difficult to determine if a focused action is active Difficult to visually determine if focused action is active Sep 30, 2024
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Nov 5, 2024
@geospatialem
Copy link
Member

Adding design for additional expertise for adoption of states in the action component.

@ashetland
Copy link
Contributor

Closing in favor of #10007.

@ashetland ashetland closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants