Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Safari: tooltip will reappear and block actions with the menu #10715

Closed
3 of 6 tasks
doreenbrinkman opened this issue Nov 8, 2024 · 3 comments
Closed
3 of 6 tasks

[Tooltip] Safari: tooltip will reappear and block actions with the menu #10715

doreenbrinkman opened this issue Nov 8, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Data Pipelines Issues logged by ArcGIS Data Pipelines team members. browser-safari Issues tied to the last 2 versions of Safari browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-11-26 - 3.0....

Comments

@doreenbrinkman
Copy link

Check existing issues

Actual Behavior

The fix to #10416 is not working for Safari.
Follow instructions in issue linked and test in Safari browser (codepen below). Working for Chrome and Firefox.

Expected Behavior

Action is not blocked by tooltip

Reproduction Sample

https://codepen.io/doreenbrinkman/pen/vYoQexP

Reproduction Steps

  1. Click on save icon
  2. Move to action
  3. Action is blocked by tooltip

Reproduction Version

2.13.2

Relevant Info

Safari

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

Makes choosing the action more difficult

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Data Pipelines
@doreenbrinkman doreenbrinkman added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Nov 8, 2024
@github-actions github-actions bot added ArcGIS Data Pipelines Issues logged by ArcGIS Data Pipelines team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 8, 2024
@geospatialem geospatialem added browser-safari Issues tied to the last 2 versions of Safari browser. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Nov 12, 2024
@geospatialem
Copy link
Member

Spike needed to determine any considerations and/or limitations to consider for support in the Safari browser.

@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Nov 12, 2024
driskull added a commit that referenced this issue Nov 15, 2024
@driskull
fix(tooltip): fix closeOnClick property in Safari. #10715
cbbcb83
@driskull driskull mentioned this issue Nov 15, 2024
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Nov 15, 2024
driskull added a commit that referenced this issue Nov 18, 2024
@driskull
fix(tooltip): fix closeOnClick property in Safari (#10737)
0479946 
**Related Issue:** #10715

## Summary

- fixes closeOnClick for the Safari browser
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 18, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

alisonailea pushed a commit that referenced this issue Nov 19, 2024
@driskull @alisonailea
fix(tooltip): fix closeOnClick property in Safari (#10737)
3345847 
**Related Issue:** #10715

## Summary

- fixes closeOnClick for the Safari browser
@DitwanP
Copy link
Contributor

DitwanP commented Nov 20, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Nov 20, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 20, 2024
benelan pushed a commit that referenced this issue Feb 8, 2025
@driskull @benelan
fix(tooltip): fix closeOnClick property in Safari (#10737)
2967622 
**Related Issue:** #10715

## Summary

- fixes closeOnClick for the Safari browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Data Pipelines Issues logged by ArcGIS Data Pipelines team members. browser-safari Issues tied to the last 2 versions of Safari browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@driskull @geospatialem @DitwanP @doreenbrinkman