Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action/Action Bar/Action Pad] Add new selectionAppearance property for 4.0 #10758

Open
2 of 8 tasks
geospatialem opened this issue Nov 18, 2024 · 0 comments
Open
2 of 8 tasks
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@geospatialem
Copy link
Member

geospatialem commented Nov 18, 2024

Draft proposal - pending user feedback

Check existing issues

Description

Improve UI/UX for action-based components to support more use cases across the design system.

Acceptance Criteria

Add a new prop, selection-appearance="highlight" | "neutral" (default) to the following components:

  • action
  • action-bar
  • action-pad

Prop set on parent Action Bar/Pad should pass to slotted Actions.

:active state colors:
selection-appearance="highlight"

selection-appearance="neutral"

  • use current :active colors

Relevant Info

Part of 4.0's Phase I - Actions effort

Which Component

  • action
  • action-bar
  • action-pad

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@ashetland ashetland self-assigned this Jan 6, 2025
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

2 participants