Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-input-time-zone need to remove console.log #10981

Closed
2 of 6 tasks
richiecarmichael opened this issue Dec 4, 2024 · 5 comments
Closed
2 of 6 tasks

calcite-input-time-zone need to remove console.log #10981

richiecarmichael opened this issue Dec 4, 2024 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2025-01-30 - 3.0....

Comments

@richiecarmichael
Copy link

richiecarmichael commented Dec 4, 2024 •
edited
Loading

Check existing issues

Actual Behavior

The input-time-zone component is generating console messages. Specifically see here.

Expected Behavior

See above

Reproduction Sample

https://codepen.io/richiecarmichael/pen/yLdwdyZ?editors=1000

Reproduction Steps

  1. Open this codepen.

Reproduction Version

Components 3.0.0-next.49

Relevant Info

Edge on Windows 10.

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@richiecarmichael richiecarmichael added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 4, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Dec 4, 2024
@driskull
Copy link
Member

driskull commented Dec 4, 2024

Maybe we should have a lint warning for console logs in tsx files. I don't see any other console.log usage in tsx files elsewhere in the codebase.

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 18, 2024
@jcfranco
Copy link
Member

@driskull Way ahead of ya! #11104

@jcfranco
Copy link
Member

jcfranco commented Dec 18, 2024 •
edited
Loading

he exclaimed confidently, 2 weeks later 😂

This was referenced Dec 18, 2024
Merged
Draft
jcfranco added a commit that referenced this issue Dec 18, 2024
@jcfranco
fix(input-time-zone): remove debugging log messages (#11106)
d7e8b36 
**Related Issue:** #10981 

## Summary

✨🧪🧹😅✨
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Dec 18, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Dec 19, 2024

🍡 Verified on 3.0.0-next.78

@DitwanP DitwanP closed this as completed Dec 19, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
5 participants
@jcfranco @driskull @richiecarmichael @geospatialem @DitwanP