Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition relevant components that use open prop to expanded per design decision #11225

Open
1 of 5 tasks
Elijbet opened this issue Jan 8, 2025 · 0 comments
Open
1 of 5 tasks
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jan 8, 2025

Description

block and list-item use open prop, but should use expanded per design decision. They need to transition to using expanded instead.

list-item has both open and closed. It looks like it should be expanded and closed.

  /** When `true`, the item is open to show child components. */
  @property({ reflect: true }) open = false;
  
  /** When `true`, hides the component. */
  @property({ reflect: true }) closed = false;

Proposed Advantages

Alignment with the design decision and consistency across components.

Which Component

block
list-item
and other relevant components

Relevant Info

Design decision: #6473
image

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 8, 2025
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

No branches or pull requests

1 participant