Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input-time-picker]: Apply openCloseComponent interface #11226

Open
2 of 5 tasks
Elijbet opened this issue Jan 8, 2025 · 0 comments
Open
2 of 5 tasks

[input-time-picker]: Apply openCloseComponent interface #11226

Elijbet opened this issue Jan 8, 2025 · 0 comments
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jan 8, 2025

Check existing issues

Description

input-time-picker has an open prop but isn’t an openCloseComponent, which is inconsistent with the rest of the components. Input-time-picker needs to be converted to apply the openCloseComponent interface.

Acceptance Criteria

Input-time-picker is an openCloseComponent.

Relevant Info

No response

Which Component

Input-time-picker

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@Elijbet Elijbet added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 8, 2025
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 8, 2025
@Elijbet Elijbet changed the title Apply openCloseComponent interface to input-time-picker [input-time-picker]: Apply openCloseComponent interface Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Elijbet