Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: [Slider] Add option to show slider value on hover #1125

Open
macandcheese opened this issue Oct 14, 2020 · 20 comments
Open

Enhancement: [Slider] Add option to show slider value on hover #1125

macandcheese opened this issue Oct 14, 2020 · 20 comments
Labels
0 - new New issues that need assignment. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
Design Backlog

Comments

@macandcheese
Copy link
Contributor

Description

It would be nice to have an option to show the value of a slider in a tooltip for cases where the persistent value doesn't need to be there

@ddred11 can you attach the screenshot of your current use case? Thanks!

Acceptance Criteria

Add an opt-in prop that shows the value of a slider on hover. Determine which prop "wins" between persisted value display and "show in tooltip on hover" (or, is both in that case ok?)

Relevant Info

Which Component

Example Use Case
@macandcheese macandcheese added the enhancement Issues tied to a new feature or request. label Oct 14, 2020
@ddred11
Copy link

ddred11 commented Oct 19, 2020

@macandcheese Here is a screen shot of a current slider experience we have in BA web. When we adopt the calcite component we would like to have this option...

Screen Shot 2020-10-14 at 3 58 59 PM

@macandcheese
Copy link
Contributor Author

cc @bstifle for reference (note - it would just use our current calcite tooltip on hover). I think this is a good addition!

@bstifle
Copy link

bstifle commented Oct 19, 2020

Dig it!!!

@ddred11
Copy link

ddred11 commented Oct 19, 2020

@macandcheese for our enterprise version, admins can change the dominant color of the app to match their branding. Does this component (and I guess most of the others) allow for this type of customization?

@macandcheese
Copy link
Contributor Author

Hey @ddred11 - yep, see this documentation page and playground: https://esri.github.io/calcite-components/?path=/story/overview-custom-theme--interactive-example

Currently you would replace the "blue" CSS variables with the desired app's branding. We may add another "brand" set of CSS variables so we can maintain blue for use cases like "info" status in the future.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 20, 2020
@macandcheese
Copy link
Contributor Author

Still valid.

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Nov 21, 2020
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 20, 2021
@macandcheese
Copy link
Contributor Author

Valid

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jan 21, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 26, 2021
@ddred11
Copy link

ddred11 commented Feb 26, 2021

@macandcheese Would be nice to add this, as we merge this component into BA. Thanks

@macandcheese
Copy link
Contributor Author

Agreed, maybe a good one for @caripizza ?

@caripizza
Copy link
Contributor

@macandcheese sure! 👍

@caripizza caripizza self-assigned this Feb 26, 2021
@caripizza caripizza removed the Stale Issues or pull requests that have not had recent activity. label Feb 26, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Mar 29, 2021
@macandcheese
Copy link
Contributor Author

Keep open

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Mar 30, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Apr 29, 2021
@macandcheese
Copy link
Contributor Author

Valid

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Apr 30, 2021
@caripizza caripizza added the 1 - assigned Issues that are assigned to a sprint and a team member. label May 13, 2021
@julio8a julio8a added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 16, 2021
@julio8a julio8a added this to the Backlog milestone Jul 16, 2021
@macandcheese
Copy link
Contributor Author

Note - ensure this shows on focus as well.

@jcfranco jcfranco modified the milestones: Freezer, Back burner Dec 21, 2021
@jcfranco jcfranco added p - low Issue is non core or affecting less that 10% of people using the library good first issue Issues that can be worked on by contributors new to calcite-components. labels Dec 21, 2021
@y0n4 y0n4 self-assigned this Feb 23, 2022
@y0n4 y0n4 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 23, 2022
@jcfranco
Copy link
Member

If the implementation of this ends up using popper or calcite-popover, it may be blocked by #3815.

@y0n4 y0n4 removed their assignment Mar 4, 2022
@y0n4 y0n4 added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 4, 2022
@brittneytewks brittneytewks added the needs triage Planning workflow - pending design/dev review. label May 31, 2023
@brittneytewks brittneytewks removed this from the Back burner milestone May 31, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Aug 21, 2023
@geospatialem
Copy link
Member

Consider as a native tooltip with an option, like #1125 (comment) or similar?

@brittneytewks brittneytewks added this to the Design Backlog milestone Aug 24, 2023
@brittneytewks brittneytewks added estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Aug 24, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
Design Backlog
Development

No branches or pull requests
10 participants
@jcfranco @alisonailea @macandcheese @geospatialem @ddred11 @julio8a @bstifle @y0n4 @caripizza @brittneytewks