Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip unstable combobox accessible tests #11297

Open
jcfranco opened this issue Jan 14, 2025 · 1 comment
Open

Unskip unstable combobox accessible tests #11297

jcfranco opened this issue Jan 14, 2025 · 1 comment
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.

Comments

@jcfranco
Copy link
Member

jcfranco commented Jan 14, 2025

Priority impact

p - high

Test type

unstable

Which Component(s)

combobox

Unstable Tests

calcite-combobox > accessible > is accessible

Test error, if applicable

@esri/calcite-components:test: ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯
@esri/calcite-components:test: 
@esri/calcite-components:test:  FAIL  src/components/combobox/combobox.e2e.ts > calcite-combobox > accessible > is accessible
@esri/calcite-components:test: Error: expect(received).toHaveNoViolations(expected)
@esri/calcite-components:test: 
@esri/calcite-components:test: Expected the HTML found at $('calcite-combobox,li[role="option"]') to have no violations:
@esri/calcite-components:test: 
@esri/calcite-components:test: <li role="option" tabindex="-1" aria-selected="false"><!--?lit$575529069$--></li>
@esri/calcite-components:test: 
@esri/calcite-components:test: Received:
@esri/calcite-components:test: 
@esri/calcite-components:test: "ARIA toggle fields must have an accessible name (aria-toggle-field-name)"
@esri/calcite-components:test: 
@esri/calcite-components:test: Fix any of the following:
@esri/calcite-components:test:   Element does not have text that is visible to screen readers
@esri/calcite-components:test:   aria-label attribute does not exist or is empty
@esri/calcite-components:test:   aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
@esri/calcite-components:test:   Element has no title attribute
@esri/calcite-components:test: 
@esri/calcite-components:test: You can find more information on this issue here: 
@esri/calcite-components:test: https://dequeuniversity.com/rules/axe/4.10/aria-toggle-field-name?application=axeAPI
@esri/calcite-components:test:  ❯ src/tests/commonTests/accessible.ts:32:7
@esri/calcite-components:test:      30|     expect(
@esri/calcite-components:test:      31|       await page.evaluate(async (componentTag: ComponentTag) => (windo…
@esri/calcite-components:test:      32|     ).toHaveNoViolations();
@esri/calcite-components:test:        |       ^
@esri/calcite-components:test:      33|   });
@esri/calcite-components:test:      34| }

PR skipped, if applicable

#11296 #11298

Additional Info

No response

@jcfranco jcfranco added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jan 14, 2025
@github-actions github-actions bot added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Jan 14, 2025
@jcfranco jcfranco self-assigned this Jan 14, 2025
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 14, 2025
@driskull
Copy link
Member

It may be because updateItems is debounced or it isn't called on connectedCallback/load

@driskull driskull changed the title Unskip unstable combobox accessible test Unskip unstable combobox accessible tests Jan 14, 2025
driskull added a commit that referenced this issue Jan 14, 2025
**Related Issue:** #11297

## Summary

- skip a11y tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Development

No branches or pull requests

2 participants