Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox value prop stale in calciteComboboxChange handler #11381

Closed
2 of 6 tasks
nwhittaker opened this issue Jan 25, 2025 · 3 comments
Closed
2 of 6 tasks

Combobox value prop stale in calciteComboboxChange handler #11381

nwhittaker opened this issue Jan 25, 2025 · 3 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p0 - emergency User set priority impact status of p0 - emergency p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@nwhittaker
Copy link
Contributor

nwhittaker commented Jan 25, 2025

Check existing issues

Actual Behavior

Given a <calcite-combobox>, selecting a combobox item triggers the calciteComboboxChange event. However, in the event's handler, the target combobox's value prop does not include the selected item.

Screen.Recording.2025-01-24.at.6.34.39.PM.mov

Expected Behavior

The target combobox's value prop does include the selected item by the time the calciteComboboxChange emits.

Screen.Recording.2025-01-24.at.6.35.36.PM.mov

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/dPbQZYW

Reproduction Steps

  1. Visit the repro and open the dev tools console.
  2. Click the combobox and select an item from the dropdown.
  3. Observe the logged combobox.value value does not include the item selected in step 2.

Reproduction Version

3.0.0-next.111

Relevant Info

Possibly related to #11382.

Regression?

2.13.2

Priority impact

impact - p0 - emergency

Impact

A workaround is to derive the value from the combobox's selectedItems prop and/or child elements. However it'd be a high level of effort to fix for every combobox instance in our code base. Requesting p0 priority as Field Maps is looking to release with Calcite 3 in a few weeks.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@nwhittaker nwhittaker added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 25, 2025
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. impact - p0 - emergency User set priority impact status of p0 - emergency labels Jan 25, 2025
@jcfranco
Copy link
Member

This was fixed by #11383.

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jan 26, 2025
Copy link
Contributor

Installed and assigned for verification.

@jcfranco jcfranco added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jan 26, 2025
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 27, 2025
@geospatialem
Copy link
Member

Verified with 3.0.0-next.113:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p0 - emergency User set priority impact status of p0 - emergency p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

4 participants