Enhancement: update component shadows per latest Figma designs

[bstifle]

In order to keep 1:1 change between light and dark theme, these changes have been vetted by design group:

• Change border radius to 4px --calcite-border-radius: 4px
• Add border-3 to light theme level 2 components
• Add border-3-dark to dark theme level 2 components
• Use foreground-1-dark on dark theme level 2 components instead of foreground-3

This applies to dropdown, alert, modal, date picker, tooltip, action pad, tip manager, popover, combobox dropdown, color picker (when it's a dropdown)

[caripizza]

@bstifle does this one still apply?

[bstifle]

Yes i believe so!

[julio8a]

checking in on this one again

[caripizza]

@julio8a @bstifle isn't this already covered in our refactors based on the Figma designs?

[julio8a]

Yes, closing.

[bstifle]

Hmm. Not seeing these shadows in our components on master @caripizza @julio8a

[caripizza]

@bstifle do the shadows appear in the Figma designs that we're using for the refactors?

[bstifle]

@caripizza yep! i wonder if this is just a shadows utility class we need to fix? other than the shadows, the other design criteria seem to be met in the issue

[caripizza]

Re-opened after clarifying the remaining work needed in this issue with Bryan (@bstifle please correct or add anything I missed from our chat).

Based on first glance, it looks like:

1. _popper.scss global styles - currently using $shadow-2 sass var - needs to instead use @apply shadow-2:
2. Additionally, the %shadow-vars sass placeholder we have here: src/assets/styles/_shadow.scss
   Don't seem to be used right now. We don't want these as global CSS Vars as far as I know, so let's remove them. As long as we have what we need in TW config under boxShadow object, we can refer to those moving forward. (But why do we have duplicate 0 and 1 values?)

@julio We should also use this issue to update the shadows content in our readme to make sure it corresponds with (or points to) the content we add in dev docs:
https://github.com/ArcGIS/afd-calcite-documentation/issues/57

[caripizza]

Can we update the description to a) articulate which components are Level 0, 1, or 2 (I don't know), and b) so we can style their shadows based on their level?

[bstifle]

@caripizza this issue is for specific components (listed in the description at the bottom) and wont apply to all components with shadows

[bstifle]

here are the depth values and which components use them:

[geospatialem]

Prioritization will be made after the 1.0 release next month.

[geospatialem]

Related issue #3122

[macandcheese]

@ashetland @SkyeSeitz proposing we close this one and address in an updated issue if this is still needed, but this seems a bit outdated at this point compared to current Figma.

[ashetland]

Agreed. Would be dealt with in #3122.

[SkyeSeitz]

Agreed. Would be dealt with in #3122.

+1