Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research: Add automated check to ensure doc and actual slot names match #2405

Open
jcfranco opened this issue Jun 26, 2021 · 1 comment
Open

Research: Add automated check to ensure doc and actual slot names match #2405

jcfranco opened this issue Jun 26, 2021 · 1 comment
Labels
0 - new New issues that need assignment. research Issues that require more in-depth research or multiple team members to resolve or make decision. tooling Issues relating to build system fixes or improvements.
Milestone
Freezer

Comments

@jcfranco
Copy link
Member

jcfranco commented Jun 26, 2021 •
edited
Loading

Background

Stems from #2394 (comment)

#2144 had an issue where the documented slot did not match with the actual slot name. Having some automated check would help catch these issues earlier.

cc @driskull

Desired Outcome

Either of the following would work to ensure correct slot name usage:

  • ESLint rule
  • Script that runs on build or test runs
  • Test util
@jcfranco jcfranco added research Issues that require more in-depth research or multiple team members to resolve or make decision. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. and removed needs triage Planning workflow - pending design/dev review. labels Jun 26, 2021
@jcfranco jcfranco self-assigned this Jul 2, 2021
@jcfranco jcfranco added this to the Sprint 8/2 – 8/13 milestone Jul 2, 2021
@jcfranco jcfranco added the tooling Issues relating to build system fixes or improvements. label Jul 2, 2021
@caripizza caripizza added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 11, 2021
@jcfranco jcfranco modified the milestones: Sprint 11/22 - 12/3, Freezer Dec 3, 2021
@jcfranco jcfranco removed their assignment Jun 30, 2022
@jcfranco jcfranco added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 30, 2022
@jcfranco
Copy link
Member Author

jcfranco commented May 5, 2024

Related stencil-community/stencil-eslint#91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. research Issues that require more in-depth research or multiple team members to resolve or make decision. tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
Freezer
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @benelan @caripizza