Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Alert - provide various placement options #3033

Closed
hccampos opened this issue Sep 14, 2021 · 5 comments
Closed

Enhancement: Alert - provide various placement options #3033

hccampos opened this issue Sep 14, 2021 · 5 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.

Comments

@hccampos
Copy link

Description

We would like to be able to place alerts in different locations.

Acceptance Criteria

  • <calcite-alert> should have a property/attribute to specify its placement.
  • Valid options could be similar to what we have to tooltips.

Relevant Info

Which Component

<calcite-alert>

Example Use Case

  • An app with a sidebar on the left side would like to place the alerts on the bottom-right corner.
  • An app with a bottom drawer would like to display the alerts on the top of the screen.

SVCH

@hccampos hccampos added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Sep 14, 2021
@macandcheese
Copy link
Contributor

I think this is reasonable.

I wonder if a slot within the shell makes sense for this, so the positioning could be controlled absolutely. Currently, it's a fixed position item which prevents the alert from staying affixed to a shell that is not full-screen (which, may be good in some cases, and not in others, so some affordance to choose this?)

I feel like we'd probably want to limit the options to top center/start/end, bottom center/start/end.

Another thing to consider would be what happens on mobile - currently we constrain max width and start / end positioned alerts at small scale may just need to become full-width.

@julio8a julio8a removed the needs triage Planning workflow - pending design/dev review. label Sep 24, 2021
@julio8a julio8a added this to the Freezer milestone Sep 24, 2021
@macandcheese
Copy link
Contributor

macandcheese commented Oct 25, 2021

Here's an initial comp with the proposed locations - would this be acceptable @hccampos?
Screen Shot 2021-10-25 at 10 21 30 AM

Some thoughts while working on these:
At a smaller screen size, these would likely all appear in the same space (top or bottom)

I wonder if alerts placed "top" would benefit from having their accent border flipped (as well as animations flipping).

This likely has implications with #2835 - to visually change the direction of the stack, and ui around multiple).

@macandcheese
Copy link
Contributor

I mentioned #2835 above - while this issue may inform that one, this one can proceed - that's not a blocker and this is a reasonably simple add.

@macandcheese macandcheese added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 2, 2021
@macandcheese macandcheese self-assigned this Dec 2, 2021
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 5, 2022
@github-actions github-actions bot assigned benelan and unassigned macandcheese Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

Installed and assigned for verification.

@benelan
Copy link
Member

benelan commented Jan 31, 2022

verified on beta.74 in the doc sample https://developers.arcgis.com/calcite-design-system/components/alert/#sample

@benelan benelan closed this as completed Jan 31, 2022
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants