Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcite-input: Form auto-fill/autocomplete does not work in all browsers #4078

Open
2 tasks done
noahmulfinger opened this issue Feb 8, 2022 · 3 comments
Open
2 tasks done
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone

Comments

@noahmulfinger
Copy link
Contributor

noahmulfinger commented Feb 8, 2022

Actual Behavior

If I have a stored credit card or address in my browser auto-fill settings, the auto-fill option only appears in Chrome (but clearing the auto-fill does not work). The auto-fill option does not appear in Firefox or Safari.

Blocked issues: #8126

Expected Behavior

I would expect auto-fill behavior similar to native form behavior across browsers.

Reproduction Sample

https://codepen.io/noahmulfinger/pen/GROjPgv

Reproduction Steps

  1. In whichever browser you are testing in, go to the setting and add a saved address.
  2. Go to the codepen and click on the first Street address field. You will see no options to fill in the fields.
  3. Click on the Street address field in the native inputs form. You should see an option to fill in the saved address (might require double-click).
  4. In Chrome, you should successfully fill in the form, but when you click again and select the Clear option, nothing will happen.

Reproduction Version

@esri/[email protected]

Relevant Info

Regression? Last working version: @esri/[email protected]. I believe this is due to the change to shadow DOM inputs in beta.70.

Source

  • CDN
  • NPM package
@noahmulfinger noahmulfinger added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 8, 2022
@mpriour
Copy link
Member

mpriour commented Feb 9, 2022

The autofill property is not passed down to the input element inside the shadow dom.

@benelan benelan removed the needs triage Planning workflow - pending design/dev review. label Feb 10, 2022
@benelan benelan added this to the Sprint 02/14 - 02/25 milestone Feb 10, 2022
@y0n4 y0n4 self-assigned this Feb 14, 2022
@y0n4 y0n4 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 14, 2022
@y0n4
Copy link
Contributor

y0n4 commented Feb 19, 2022

There's been several discussions from other devs regarding this issue for autofill managers not properly filling inputs in shadow dom components for a while now. Fortunately there has been a recent mention as of a week ago of an update readying to get launched for this issue in Chrome browsers. However, I haven't spotted any followup discussions on other browsers like firefox/safari.

May have to table this issue to freezer once there is an browser enhancement update

@jcfranco
Copy link
Member

Thanks for the breakdown, @y0n4. Going to put this one in the freezer for now. cc @benelan

FWIW, here are some additional browser bug reports on shadow DOM + autocomplete:

https://bugzilla.mozilla.org/show_bug.cgi?id=1629226
https://bugzilla.mozilla.org/show_bug.cgi?id=1644302
https://bugs.webkit.org/show_bug.cgi?id=172567

@jcfranco jcfranco added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 23, 2022
@benelan benelan added the blocked This issue is blocked by another issue. label Feb 23, 2022
@benelan benelan self-assigned this Nov 22, 2022
@benelan benelan added the 1 - assigned Issues that are assigned to a sprint and a team member. label Nov 22, 2022
@benelan benelan removed their assignment Dec 12, 2022
@benelan benelan removed the 1 - assigned Issues that are assigned to a sprint and a team member. label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

No branches or pull requests

7 participants