Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit form util to only have the topmost form owner handle all the form logic #4506

Closed
driskull opened this issue May 9, 2022 · 5 comments
Labels
0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. refactor Issues tied to code that needs to be significantly reworked. spike complete Issues that have a research spike completed and dev work can proceed

Comments

@driskull
Copy link
Member

driskull commented May 9, 2022

Description

Revisit form util to only have the topmost form owner handle all the form logic

Proposed Advantages

Only the parent top-most form control will handle sending data to the form. This eliminates conflicting form components sending data to the form and uses less event listeners so performance should be better.

Which Component

All form supported components.

Relevant Info

#4439 (review)

@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 9, 2022
@eriklharper
Copy link
Contributor

What's the use case for having nested <form> elements?

@driskull
Copy link
Member Author

driskull commented May 9, 2022

Using our own components inside shadowRoot of others.

@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Oct 16, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Oct 16, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Oct 16, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 16, 2023
@jcfranco
Copy link
Member

I believe this may no longer be valid. Only the topmost form component handles interacting with the parent form (following our form component pattern). Child form components do have the plumbing to associate themselves with a form, but it depends on them receiving a form property (topmost form component handles and does not pass along) or having an associated form field name (both set by users).

@jcfranco jcfranco added the spike complete Issues that have a research spike completed and dev work can proceed label Nov 14, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 14, 2023
Copy link
Contributor

cc @geospatialem, @brittneytewks

@jcfranco
Copy link
Member

I'm going to go ahead and close this based on ☝️. #8126 should help streamline our form components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. refactor Issues tied to code that needs to be significantly reworked. spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

6 participants