Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public events for accordion, accordion-item #4531

Open
2 tasks
jgibson02 opened this issue May 11, 2022 · 3 comments
Open
2 tasks

Public events for accordion, accordion-item #4531

jgibson02 opened this issue May 11, 2022 · 3 comments
Labels
0 - new New issues that need assignment. ArcGIS Hub Issues logged by ArcGIS Hub team members. blocked This issue is blocked by another issue. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone

Comments

@jgibson02
Copy link
Contributor

Description

To support programmatically focusing certain, there should be public events to notify when accordion-items are opened/closed.

Acceptance Criteria

  • Public calciteAccordionChange event for accordion
  • Public events for accordion-item for open & close

Relevant Info

No response

Which Component

accordion, accordion-item

Example Use Case

In forms with several complex sections, there may be need to programmatically set the active prop of an accordion-item, e.g. to prompt the user for a required form control. If you had a piece of state with a boolean that was setting this active prop, then you would need to listen for when the user clicks on an accordion-item. You can currently (at least with the React wrapper) add an onClick event, but this would also fire when clicking anywhere inside the accordion-item's content.

image

@jgibson02 jgibson02 added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 11, 2022
@ReneU
Copy link

ReneU commented Jul 1, 2022

+1 this would also be helpful for our migration as we hide some 'expensive' components (such as the ArcGIS JS API) initially and only lazy load the content when the user opens the accordion item:
image

@geospatialem geospatialem added epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Oct 16, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 6, 2023
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. and removed estimate - 5 A few days of work, definitely requires updates to tests. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. labels May 6, 2024
@jcfranco
Copy link
Member

jcfranco commented May 7, 2024

Public events for accordion-item for open & close

This is blocked by #6473. cc @geospatialem

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label May 7, 2024
@abp6318
Copy link
Contributor

abp6318 commented Sep 24, 2024

+1 for ArcGIS Hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Hub Issues logged by ArcGIS Hub team members. blocked This issue is blocked by another issue. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

6 participants