Combobox: allow enter of custom chips on , key

[paulcpederson]

Description

We have a tags component which we'd like to allow users to use the comma key as if it was Enter. Receiving multiple reports of users using comma and expecting it to separate them as this is what our previous UI did.

Acceptance Criteria

After typing a term, if using custom-values, typing a comma should act identically to Enter

Relevant Info

No response

Which Component

calcite-combobox

Example Use Case

No response

[jcfranco]

@macandcheese @paulcpederson Would we ever need to match , from combobox items? This is the only concern I have if we use it to commit custom values.

[paulcpederson]

Yeah that's a good question. Maybe this is a configurable prop?

[jcfranco]

Here are some options I see:

1. always use , to commit (consistent, but we potentially lose matching commas in items)
2. add prop to include , to commit values (could lead to inconsistent behavior/expectations)
3. add prop to allow extra committing keys (could lead to inconsistent behavior/ expectations more so than ☝️)
4. do nothing and only use Enter (consistent, but may require 'retraining' users)

[paulcpederson]

I wonder if there is another way like adding an event on keypress and letting devs wire this up themselves (with a method for tag entry). Similar in concept to #2527 where it's very open ended

[jcfranco]

I think this is different. I see the value in allowing devs to process custom values, but I don't understand why we need to make the value commit experience customizable. I would expect our combobox's UX for entering custom chips to work the same regardless of the context.

[ashetland]

Related issue #10499 improves the UX of adding custom items. Could be expanded to account for adding multiple items to address this issue.