Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split input to type-specific components #5144

Closed
3 of 9 tasks
jcfranco opened this issue Aug 12, 2022 · 2 comments
Closed
3 of 9 tasks

Split input to type-specific components #5144

jcfranco opened this issue Aug 12, 2022 · 2 comments
Labels
epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project.

Comments

@jcfranco
Copy link
Member

jcfranco commented Aug 12, 2022

Overview

<calcite-input> has grown in complexity and has introduced some mixed messaging in terms of the types it supports as it started mimicking the native <input>. This effort aims to
split the component into simpler, focused type-specific components.

Additionally, we've identified <calcite-inline-editable> as an input-like that slightly modifies input's UX and depends on users slotting an input, which is not a common pattern between existing components.
Assimilating it into all inputs would make it simpler for developers to set up and will make input patterns more consistent.

Tasks

For 1.0.0, <calcite-input> will be split up into the following:

  1. calcite-input-textfeat(input-text): create separate component for input type text #4946
  2. calcite-input-numberfeat(input-number): create separate component for input type number #4870
  3. calcite-input-date – calcite-input-date-picker will be renamed
  4. calcite-input-timeEnhancement: Add input masking to input-time-picker #2709 calcite-input-time-picker will be renamed
  5. calcite-input-color - New Component: calcite-input-color-picker  #1616, New Component: input-color #1934
  6. calcite-text-area - New Component: calcite-text-area #863

Separate from ☝️,

  1. update inputs with inline-editable behavior common for all inputs (separate enhancement issue)
  2. decide the purpose of calcite-input after splitting (could be repurposed as a fallback native input if we only apply styles to a native input and drop shadow DOM) – we'll keep calcite-input as a way for users to use types we don't support yet and to help us gauge feedback on missing types
  3. introduce an input documentation page, showcasing supported types, and common patterns (doc issue?)

Notes

  • inputs should share code through utils, functional components, additional patterns
  • inline-editable behavior needs to be vetted by design per input type

cc @benelan @geospatialem

@jcfranco jcfranco added the epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. label Aug 12, 2022
@geospatialem geospatialem added this to the 2023 January Priorities milestone Nov 23, 2022
@geospatialem
Copy link
Member

Reallocating the above into February's release.

@geospatialem
Copy link
Member

Closing out in favor of other epics, #6566, and a newly created (internal) documentation issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project.
Projects
None yet
Development

No branches or pull requests

3 participants