Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell: Add slots for displaying content at the top/start and bottom/end of the center. #5668

Closed
driskull opened this issue Oct 31, 2022 · 5 comments
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@driskull
Copy link
Member

driskull commented Oct 31, 2022

Description

Allow users to place floating content over the top and bottom of the default slotted content center content.

These slots can be called something like center-start and center-end or something similar. We can eventually deprecate and phase out the center-row slot.

Other suggestions:

  • content-start/content-end

Acceptance Criteria

Ability to place floating content at the top and bottom over the default slotted content.

Relevant Info

https://community.esri.com/t5/calcite-design-system-questions/align-calcite-panel-to-bottom-of-the-screen/m-p/1227083#M266

Which Component

calcite-shll

Example Use Case

<calcite-shell>
  <calcite-panel slot="center-start"></calcite-panel>
  <calcite-panel slot="center-end"></calcite-panel>
</calcite-shell>

Esri team

N/A

@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 31, 2022
@macandcheese
Copy link
Contributor

macandcheese commented Oct 31, 2022

@driskull - Functionality like this is included in the proposal for updated shell / shell panel behavior. Should have more on that over next couple of weeks. cc @asangma @mitc7862

@benelan benelan added the Calcite (dev) Issues logged by Calcite developers. label Nov 15, 2022
@bluespider42
Copy link

This isn't quite what I had meant in my forum post.
I was meaning for an ability to have a Panel alligned with the bottom of the screen inside a Shell-Panel. This could be done to match the action-bar whcih has bottom-actions slot. So a Shell-Panel could have a bottom-panels slot or something similar.

@macandcheese
Copy link
Contributor

@bluespider42 would it be possible to attach a screenshot, sketch, or mock-up of what you mean, so we can better understand the request? Thanks!

@bluespider42
Copy link

bluespider42 commented Nov 17, 2022

panel

Sorry, I'm not sure how best to illustrate this. But with the action bar you can have the action at the bottom of the action-bar, as a user I would expect this to open the panel at the bottom left corner.

However, I would also find the proposal as stated in this issue a useful feature.

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Jan 24, 2024
@geospatialem
Copy link
Member

Added additional acceptance criteria and context to the related issue. Closing in favor of the efforts of #1932.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

6 participants