Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovering over the calcite alert when saving a map will not automatically dismiss #6222

Closed
rebollin opened this issue Jan 3, 2023 · 8 comments
Closed

Hovering over the calcite alert when saving a map will not automatically dismiss #6222

rebollin opened this issue Jan 3, 2023 · 8 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests.
Milestone
2023 January Prio...

Comments

@rebollin
Copy link

rebollin commented Jan 3, 2023

Description

The final calcite alert for saving in Map Viewer will not automatically dismiss after a certain allotment of time. This seems to happen after the user hovers over the previous notifications. Talked with @geospatialem and it is likely a result of this PR #5872. Here is a codepen for this issue: https://codepen.io/kevindoshier/pen/ZEjQPjB

savefreezing

Acceptance Criteria

The alert should automatically dismiss after the allotted time rather than having the user manually close it.

Relevant Info

No response

Which Component

alert component

Example Use Case

No response

Esri team

ArcGIS Map Viewer
@rebollin rebollin added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 3, 2023
@github-actions github-actions bot added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Jan 3, 2023
@geospatialem
Copy link
Member

Could see a use case for potentially having the alert not dismiss automatically when pausing due to hovering (and eventually focusing via #5960).

Should we consider introducing a boolean property to handle both use cases?

Will evaluate prioritization after this month's 1.0 release for a future milestone and/or assignment.

@macandcheese
Copy link
Contributor

I think we should prioritize the bug fix for 1.0, if we can.

Could see a use case for potentially having the alert not dismiss automatically when pausing due to hovering (and eventually focusing via #5960).

I think this would just be a use case to not have the auto-dismiss property enabled at all by an app. I would expect the dismiss timer to resume once hover / focus leaves, I feel like having an option to "leave the timer halfway done" is kind of strange?

There is precedent for a no-hover-pause property: (https://bootstrap-vue.org/docs/components/toast#comp-ref-b-toast-props), but slightly unrelated I suppose.

@geospatialem
Copy link
Member

Adding to the January milestone, if time permits from the team to tackle.

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jan 3, 2023
@geospatialem geospatialem added this to the 2023 January Priorities milestone Jan 3, 2023
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. and removed enhancement Issues tied to a new feature or request. labels Jan 3, 2023
@macandcheese macandcheese mentioned this issue Jan 4, 2023
Merged
@macandcheese
Copy link
Contributor

macandcheese commented Jan 4, 2023 •
edited
Loading

Somewhat separately from the component bug, looking again at the gif provided, I think invoking the “saving” alert, then removing it without user interaction to replace it with another “save complete” alert is a bit of a weird experience, and might feel broken to a user.

Alternatively, a loading state / loading spinner could be used on the folder action in the action bar for the duration of the save, instead of the initial “saving” alert - then just provide a single success alert.

@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 4, 2023
@macandcheese macandcheese self-assigned this Jan 4, 2023
macandcheese added a commit that referenced this issue Jan 5, 2023
@macandcheese
fix(alert): Correctly dismiss after hovering (#6228)
66dd692 
**Related Issue:** #6222 

## Summary
This should fix the problem described in the issue - it now handles
multiple "hover on and off" events and, at least in local testing, seems
to handle large queues that may be present pretty well. The events used
were changed to fire less often, and there's an accrued timer of hover
time that now is used to determine remaining duration before dismissal.

The watcher for changing the duration now resets it to the default, so
unless a user interacts with the alert, it may display for a bit longer.
Although, I can't think of a use case where this would be changed while
an alert is open, we do use it in demos, and we could refactor this code
to better support that if needed.


https://user-images.githubusercontent.com/4733155/210485461-c77e8948-af76-4c61-b965-306fc0a9d973.mov
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 5, 2023
@github-actions github-actions bot assigned geospatialem and unassigned macandcheese Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Installed and assigned for verification.

@macandcheese
Copy link
Contributor

@rebollin @kevindoshier this should be available to test on next release if you could give a look and test it out :)

Would also recommend the UX suggestion above be implemented, check with @asangma for interaction details there.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 5, 2023
@geospatialem
Copy link
Member

Verified on next.710.
verify-alert-auto-close

@rebollin
Copy link
Author

This looks good on MV now after the latest update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests.
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @rebollin