Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into stripping out testing data- attributes from production code. #6760

Open
driskull opened this issue Apr 10, 2023 · 2 comments
Open

Look into stripping out testing data- attributes from production code. #6760

driskull opened this issue Apr 10, 2023 · 2 comments
Labels
0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision.
Milestone
2025-08-26 - Aug ...

Comments

@driskull
Copy link
Member

driskull commented Apr 10, 2023 •
edited by geospatialem
Loading

Background

#6746 (comment)

Desired Outcome

Any data attributes or testing specific code is removed from the production code.

May have some risk involved and it could impact current component functionality. 🚧
@driskull driskull added research Issues that require more in-depth research or multiple team members to resolve or make decision. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 10, 2023
@driskull driskull mentioned this issue Apr 10, 2023
Merged
@jcfranco jcfranco mentioned this issue Nov 14, 2023
Draft
@jcfranco
Copy link
Member

I think I have something we could use for this: #8171.

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Apr 2, 2024
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 30, 2024
@driskull
Copy link
Member Author

We could convert all the data-test attributes to id. there aren't too many

image

@driskull driskull mentioned this issue Aug 22, 2024
Merged
@DitwanP DitwanP added this to the 2025-08-26 - Aug Milestone milestone Jan 3, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision.
Projects
None yet
Milestone
2025-08-26 - Aug Milestone
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @DitwanP