Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to restrict character input to calcite-input-time-picker #6898

Closed
BennyBaruba opened this issue May 2, 2023 · 3 comments
Closed
Labels
0 - new New issues that need assignment. ArcGIS Mission Issues logged by ArcGIS Mission team members. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@BennyBaruba
Copy link

BennyBaruba commented May 2, 2023

Description

As it stands now, users can input any characters into the calcite-input-time-picker.

image

This enhancement is a request to add the ability to restrict what characters can be typed in directly to the calcite-input-time-picker. For english the user should only be able to type in 2 numbers for each the hour, minutes and seconds and only am or pm in a 12 hour format.

Acceptance Criteria

  • calcite-input-time-picker only allows the correct characters to be manually typed in

Relevant Info

A similar issue exists with the calcite-input-date-picker.

image

Which Component

calcite-input-time-picker

Example Use Case

image

Priority impact

p4 - not time sensitive

Esri team

ArcGIS Mission

@BennyBaruba BennyBaruba added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels May 2, 2023
@github-actions github-actions bot added ArcGIS Mission Issues logged by ArcGIS Mission team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels May 2, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Apr 2, 2024
@geospatialem
Copy link
Member

Should we consider using error handling for a solution and/or strip out invalid values? For instance, Atlassian will let the user type in a value and then reset once the component's blurred.

@DitwanP DitwanP added needs triage Planning workflow - pending design/dev review. and removed design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review. labels Apr 11, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Apr 11, 2024

We want masked inputs for time-picker.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time

@geospatialem
Copy link
Member

Closing in favor of #2709, where masking will be considered as part of the effort,

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Mission Issues logged by ArcGIS Mission team members. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants