Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab-Title]: tabs no longer center with layout="center" #7025

Closed
Elijbet opened this issue May 24, 2023 · 4 comments
Closed

[Tab-Title]: tabs no longer center with layout="center" #7025

Elijbet opened this issue May 24, 2023 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
1.4.1 May patch -...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented May 24, 2023 •
edited
Loading

Actual Behavior

Screenshot 2023-05-24 at 2 37 23 PM

Reproduction Sample

https://codepen.io/nsulzberger_esri/pen/MWPLRgB

Reproduction Version

1.4.0

Relevant Info

Possible fix: :host([centered]) .content { @apply mi-auto; } on or around https://github.com/Esri/calcite-components/blame/master/src/components/tab-title/tab-title.scss#L95

Possible workaround: https://codepen.io/mpriour/pen/bGmzJZm

Regression?

Regression caused by #2620

Priority impact

p1 - need for current milestone

Esri team

Calcite (dev)
@Elijbet Elijbet added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 24, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels May 24, 2023
@Elijbet Elijbet self-assigned this May 24, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 24, 2023
@jcfranco jcfranco added this to the 1.4.1 May patch - Bugs only milestone May 24, 2023
@jcfranco jcfranco added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library 2 - in development Issues that are actively being worked on. and removed needs triage Planning workflow - pending design/dev review. 1 - assigned Issues that are assigned to a sprint and a team member. labels May 24, 2023
@jcfranco jcfranco mentioned this issue May 25, 2023
Merged
Elijbet added a commit that referenced this issue May 26, 2023
@Elijbet
fix(tab-title): tabs center when set to layout='center' (#7026)
0bd677b 
**Related Issue:** #7025

## Summary
Enhancement to `tab-title` to make it optionally `closable` introduced
structural changes that caused a regression in the tab alignment when
centered.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 26, 2023
@github-actions github-actions bot assigned geospatialem and unassigned Elijbet May 26, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 26, 2023
@geospatialem geospatialem assigned Elijbet and unassigned geospatialem May 26, 2023
@Elijbet Elijbet mentioned this issue May 26, 2023
Merged
Elijbet added a commit that referenced this issue May 27, 2023
@Elijbet
fix(tab-nav): justify centered tab-titles evenly to extend across t…
8ef0421 
…he width of `tab-nav` (#7047)

**Related Issue:** #7025 

## Summary

Follow-up to fix to #7026.

Centered `tabs` should spread the `tab-titles` evenly to extend across
the entire width of `tab-nav`, as opposed to `inline tab-titles` that
only justify against the start of `tab-nav` width.

Added coverage for both `centeredTabsAreEvenlyJustifiedAcrossNavWidth`
and `inlineTabsJustifyAgainstTheStartOfTheNavWidth`.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 27, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 27, 2023
@geospatialem
Copy link
Member

Verified in master.

@nsulzberger
Copy link

thanks a lot for fixing this, it looks fine now in Scene Viewer with 1.4.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
1.4.1 May patch - Bugs only
Development

No branches or pull requests
4 participants
@jcfranco @nsulzberger @geospatialem @Elijbet