Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab-Title]: truncate text past certain length #7068

Closed
Elijbet opened this issue May 31, 2023 · 2 comments
Closed

[Tab-Title]: truncate text past certain length #7068

Elijbet opened this issue May 31, 2023 · 2 comments
Assignees
@Elijbet
Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-03-26 - Mar ...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented May 31, 2023 •
edited
Loading

Description

Truncate the tab-title text when it reaches 8px away from the x-button at all scales. This is a better behavior than the current wrapping.

Stems from: #7026

This would need to have the tooltip applied for sighted users, just like the truncated button does (or any component with a set height).

More specifically, an HTML label should be used to reveal the full text for sighted users, and the calcite-tooltip is to provide additional context where needed.

Figma layout from @SkyeSeitz
image

Acceptance Criteria

Long text is truncated and an html tooltip is provided for sighted users.

Relevant Info

No response

Which Component

tab-title

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

Calcite (dev)
@Elijbet Elijbet added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 31, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels May 31, 2023
@Elijbet Elijbet mentioned this issue May 31, 2023
Open
10 tasks
@Elijbet Elijbet self-assigned this Aug 18, 2023
@geospatialem geospatialem added design Issues that need design consultation prior to development. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 23, 2023
@brittneytewks brittneytewks added the ready for dev Issues ready for development implementation. label Aug 24, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 24, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@brittneytewks brittneytewks added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Aug 24, 2023
@brittneytewks brittneytewks added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 28, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Sep 6, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@geospatialem
Copy link
Member

Closing in favor of the responsive design and design changes proposed and targeted for this milestone via #6689.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Elijbet Elijbet

Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-03-26 - Mar Release
Development

No branches or pull requests
3 participants
@geospatialem @Elijbet @brittneytewks