Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell / Shell Panel]: Allow slotted displayMode: float Shell Panels to position absolutely #7199

Closed
macandcheese opened this issue Jun 20, 2023 · 3 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jun 20, 2023

Description

Currently, when using Shell (without content-behind), there really is no use for the "float" displayMode value - it positions itself over a swim lane and has a "floating shadow" - but it is not positioned absolutely over main slotted content area.

This means that layouts with one "dock" and one "float" slotted Shell Panel cannot be achieved without content-behind, which is not always desirable.

Acceptance Criteria

In a Shell (without content-behind), the "float" value of displayMode behaves as an absolutely positioned element, and truly "floats" above the content. It should behave similarly to "float" when content-behind is set on Shell.

Relevant Info

While it seems we want to keep content-behind for the time being as it can be useful for certain mapping needs, adjusting the "non content-behind" Shell story in this way will allow more layouts to be achieved.

Which Component

Shell / Shell Panel

Example Use Case

Current with a "float" Shell Panel slotted in "panel-end":
Screen Shot 2023-06-20 at 9 35 32 AM

Desired with a "float" Shell Panel slotted in "panel-end":
Screen Shot 2023-06-20 at 9 36 00 AM

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)

@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 20, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. p3 - want for upcoming milestone labels Jun 20, 2023
@macandcheese
Copy link
Contributor Author

+1 from UC customer

@macandcheese
Copy link
Contributor Author

Related: #1932

@geospatialem
Copy link
Member

Added additional acceptance criteria and context to the related issue. Closing in favor of the efforts of #1932.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants