Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs / Tab Nav / Tab Title] When used outside Tabs, selected prop and style not correctly applied to Tab Title #7512

Closed
2 of 3 tasks
macandcheese opened this issue Aug 11, 2023 · 8 comments
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Aug 11, 2023

Check existing issues

Actual Behavior

Currently, when using Tab Nav outside the Tabs component - the active underline bar accurately moves, but the component does not receive the selected property or related styles:

Screenshot 2023-08-11 at 2 59 49 PM

Expected Behavior

When using Tab Nav outside the Tabs component as documented, have the selected prop accurately update.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/XWyLYmm?editors=1000

Reproduction Steps

  1. visit Codepen
  2. change both tabs
  3. Notice the property not applied to the first Tab Nav

Reproduction Version

1.4.3

Relevant Info

If we do say Tabs is required to wrap a Tab Nav, maybe we can not render the border or any padding / margin when no Tab component are provided. I do think the Tab Nav on its own is valid, for example if slotted somewhere it is impractical to use adjacent div, and an app uses the Tab Nav events to show / hide their own content.

Related - #2721

cc @mitc7862

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)

@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 11, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Aug 11, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 21, 2023
@geospatialem
Copy link
Member

Consider as part of refactor to the related (also mentioned above) #2721

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Dec 18, 2023
@geospatialem
Copy link
Member

Spike to confirm if tab-nav can be used independently. If not, should consider closing this and update the documentation page with additional context/workflow patterns for folks.

@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 18, 2023
@jcfranco
Copy link
Member

jcfranco commented Jan 4, 2024

It looks like standalone tab-nav worked prior to v1, but since then, there doesn't seem to be any documentation or examples about standalone usage (the closest thing I found was this demo page update and original basic usage file). From that perspective, the component is behaving as expected, but I agree with @macandcheese's point about tab-nav potentially being useful by itself for some use cases. @macandcheese could you share more info on your use case and the priority/impact?

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. labels Jan 4, 2024
@macandcheese
Copy link
Contributor Author

I don’t have one for anything I’m working on, but it was a supported case that stopped working.

I’m fine to just not support this if no one else reported it - as it hasn’t worked in a long time - especially if this coincides with a larger component refactor to Tab component / Tab Group.

@jcfranco
Copy link
Member

jcfranco commented Jan 4, 2024

I don’t have one for anything I’m working on, but it was a supported case that stopped working.

Yeah, this use case was a bit inconspicuous before we went out of beta. Unless any of the existing props are related to this behavior (I think they're unrelated), I'd like to propose either backlogging or closing until we get more requests for this use case. cc @geospatialem

@jcfranco jcfranco added the spike complete Issues that have a research spike completed and dev work can proceed label Jan 4, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 4, 2024
@github-actions github-actions bot removed this from the 2024-01-17 - Jan Main Release milestone Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

cc @geospatialem, @brittneytewks

@macandcheese
Copy link
Contributor Author

Agreed - Menu should be able to solve for use cases where this was implemented. I'd suggest closing and folks can open new issues if needed.

@geospatialem
Copy link
Member

Closing per #7512 (comment) and #7512 (comment).

If the use case comes up in the future we can explore alternative methods, or to Adam's point above, potentially could be solved using menu.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

3 participants