-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs / Tab Nav / Tab Title] When used outside Tabs, selected prop and style not correctly applied to Tab Title #7512
Comments
Consider as part of refactor to the related (also mentioned above) #2721 |
Spike to confirm if |
It looks like standalone |
I don’t have one for anything I’m working on, but it was a supported case that stopped working. I’m fine to just not support this if no one else reported it - as it hasn’t worked in a long time - especially if this coincides with a larger component refactor to Tab component / Tab Group. |
Yeah, this use case was a bit inconspicuous before we went out of beta. Unless any of the existing props are related to this behavior (I think they're unrelated), I'd like to propose either backlogging or closing until we get more requests for this use case. cc @geospatialem |
Agreed - Menu should be able to solve for use cases where this was implemented. I'd suggest closing and folks can open new issues if needed. |
Closing per #7512 (comment) and #7512 (comment). If the use case comes up in the future we can explore alternative methods, or to Adam's point above, potentially could be solved using |
Check existing issues
Actual Behavior
Currently, when using Tab Nav outside the Tabs component - the active underline bar accurately moves, but the component does not receive the
selected
property or related styles:Expected Behavior
When using Tab Nav outside the Tabs component as documented, have the
selected
prop accurately update.Reproduction Sample
https://codepen.io/mac_and_cheese/pen/XWyLYmm?editors=1000
Reproduction Steps
Reproduction Version
1.4.3
Relevant Info
If we do say Tabs is required to wrap a Tab Nav, maybe we can not render the border or any padding / margin when no Tab component are provided. I do think the Tab Nav on its own is valid, for example if slotted somewhere it is impractical to use adjacent div, and an app uses the Tab Nav events to show / hide their own content.
Related - #2721
cc @mitc7862
Regression?
No response
Priority impact
p3 - want for upcoming milestone
Impact
No response
Calcite package
Esri team
Calcite (design)
The text was updated successfully, but these errors were encountered: