Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into ways to speed up commonTest helper runs. #7706

Closed
1 of 2 tasks
Elijbet opened this issue Sep 8, 2023 · 1 comment
Closed
1 of 2 tasks

Look into ways to speed up commonTest helper runs. #7706

Elijbet opened this issue Sep 8, 2023 · 1 comment
Assignees
@Elijbet
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Sep 8, 2023 •
edited
Loading

Description

Look into ways to speed up commonTest helper runs by:

  1. moving some of the commonTest helpers to be spec tests rather than E2E tests. E2E tests take longer to set up and run. newSpecPage() is much faster since it does not require a full Puppeteer instance to be running. Stencil Docs on newSpecPage()

  2. exploring testing class logic directly. This approach allows you to test the component's class logic without the need for a full rendering setup. Stencil Docs on Testing Component Class Logic

Proposed Advantages

These approaches can help improve test execution time and overall efficiency.

Which Component

General refactor of the commonTest utils.

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 8, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Sep 8, 2023
@Elijbet Elijbet changed the title Look into ways to speed up commonTest helper runs. Look into ways to speed up commonTest helper runs. Sep 8, 2023
@Elijbet Elijbet self-assigned this Sep 8, 2023
@Elijbet
Copy link
Contributor Author

Elijbet commented Sep 8, 2023

Merging this with existing #2877.

@Elijbet Elijbet closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Elijbet Elijbet

Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Elijbet