[Modal] calciteModalClose should not fire when open prop is toggled to false

[rpanichakit9541]

Check existing issues

• I have checked for existing issues to avoid duplicates

Actual Behavior

Currently, calciteModalClose event fires both when "X" is clicked or if the open prop is toggled to false.

Expected Behavior

I asked @driskull and he said it should only fire on "X" click and not when open is toggled to false.

Reproduction Sample

https://codepen.io/rpanichakit/pen/qBLmRRN?editors=1001

Reproduction Steps

1. Open modal
2. click "Cancel"
3. observe "close event" output to the console

Reproduction Version

1.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

• @esri/calcite-components
• @esri/calcite-components-react

Esri team

ArcGIS Online

[geospatialem]

Add a doc example where user events can be tracked (via keyboard/click) vs. if toggled via an attribute/prop.

[geospatialem]

Re-assigning the documentation update to the January 2024, in alignment and in consideration with the efforts of #3818, where we can explore a new documentation page that contains information on open and additional patterns such as validation, animation, and references mentioned in #3818 (comment).

In the meantime, this is the expected pattern with regards to the open and close events, which are asynchronous as a result of animations. Calcite emits both when setting the property, or when the user closes/opens the component.

The pattern will also be addressed via PR #7613 and issue #4398.

[geospatialem]

Re-assigning the documentation update to the January 2024, in alignment and in consideration with the efforts of #3818, where we can explore a new documentation page that contains information on open and additional patterns such as validation, animation, and references mentioned in #3818 (comment).

In the meantime, this is the expected pattern with regards to the open and close events, which are asynchronous as a result of animations. Calcite emits both when setting the property, or when the user closes/opens the component.

The pattern will also be addressed via PR #7613 and issue #4398.

We should reconsider the doc update for 2025 timings, as the above has changed in scope. Updated the doc update priority to p - low to address in the future.