Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable Combobox Groups #7734

Open
3 tasks done
LeviRemi opened this issue Sep 13, 2023 · 3 comments
Open
3 tasks done

Clickable Combobox Groups #7734

LeviRemi opened this issue Sep 13, 2023 · 3 comments
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-combobox Issues that pertain to the calcite-combobox and related components calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@LeviRemi
Copy link

Check existing issues

Description

Allow for Combobox Item Group to be clickable, triggering a selection (or deselection) of all items in the group.

Acceptance Criteria

Allow developers to toggle a Combobox Item Group as clickable, and configure an event handler on that click wherein the event provides access to all selected elements in the group.

Relevant Info

I suggest that an Item Group's click-ability should be optional, and should impact the visual/hover interaction of the element so it is clear that the group is clickable.

Which Component

Combobox Item Group

Example Use Case

This would be especially helpful for large combobox lists where it is common for a user to want to select all items in a given group. That is the use-case we have encountered with our customer, and we have had to work around this limitation.

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Professional Services - Services Delivery

@LeviRemi LeviRemi added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Sep 13, 2023
@github-actions github-actions bot added Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. labels Sep 13, 2023
@geospatialem geospatialem added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label Sep 13, 2023
@hgonzago
Copy link
Member

Just to piggy-back off of this. We have had quite a few discussions over the best way to handle feature template display within the JS SDK Editor widget. This widget is used in various apps and would benefit tremendously by providing this functionality.

cc/ @JonUihlein

@avezina @tristan-morrison

@geospatialem geospatialem added design Issues that need design consultation prior to development. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Sep 18, 2023
@geospatialem
Copy link
Member

Some discussion points:

  • Design expertise is needed to determine if other design systems have similar support (spike)
    • Are there examples "in the wild"?
  • Accessibility should be considered as part of the supporting effort

@ashetland
Copy link
Contributor

We could revise these designs for Select All for Combobox Items (#2311) to also include a select all for groups.

It seems like from the above that "the group is clickable" is only related to selecting all the items in that group. Am I understanding that correctly?

@ashetland ashetland added c-combobox Issues that pertain to the calcite-combobox and related components 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library and removed 0 - new New issues that need assignment. labels Sep 21, 2023
@ashetland ashetland self-assigned this Sep 21, 2023
@ashetland ashetland removed the needs triage Planning workflow - pending design/dev review. label Sep 21, 2023
@ashetland ashetland added this to the Design Next milestone Sep 21, 2023
@ashetland ashetland added the estimate - design - sm Small design effort; 1-4 days of design work label Oct 31, 2023
@ashetland ashetland removed their assignment Jul 11, 2024
@DitwanP DitwanP removed this from the Design Backlog milestone Aug 8, 2024
@ashetland ashetland self-assigned this Sep 27, 2024
@ashetland ashetland added p - low Issue is non core or affecting less that 10% of people using the library and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Dec 2, 2024
@ashetland ashetland removed their assignment Dec 2, 2024
@ashetland ashetland removed the 1 - assigned Issues that are assigned to a sprint and a team member. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-combobox Issues that pertain to the calcite-combobox and related components calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

6 participants