Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs]: Refactor the mutationObserver to invoke when nested children are added/removed #8078

Open
1 of 4 tasks
Elijbet opened this issue Oct 29, 2023 · 1 comment
Open
1 of 4 tasks

[Tabs]: Refactor the mutationObserver to invoke when nested children are added/removed #8078

Elijbet opened this issue Oct 29, 2023 · 1 comment
Labels
0 - new New issues that need assignment. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-05-13 - 3.2....

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Oct 29, 2023 •
edited
Loading

Description

A follow-up to issue #7605.

The current configuration of the mutation observer would only be invoked when direct children are added/removed. Since tab-titles are children of tab-nav the observer would miss these.

Mutations from other children might be helping update the tab-titles, but needs to be improved for the current milestone.

Proposed Advantages

Make the observer work as intended.

Which Component

tabs

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone estimate - 2 Small fix or update, may require updates to tests. p3 - want for current milestone and removed impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Oct 29, 2023
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for current milestone labels Mar 19, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jun 25, 2024
@geospatialem
Copy link
Member

Revisit after the spike of #2721 to determine if the above is still valid and worthwhile in pursuring.

@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-05-13 - 3.2.0 May Main Release
Development

No branches or pull requests
3 participants
@geospatialem @Elijbet @DitwanP