Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell-panel : rename position property to actionBarPosition #8306

Open
1 of 5 tasks
anveshmekala opened this issue Nov 30, 2023 · 4 comments
Open
1 of 5 tasks

Shell-panel : rename position property to actionBarPosition #8306

anveshmekala opened this issue Nov 30, 2023 · 4 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 5 A few days of work, definitely requires updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-02-25 - Feb ...

Comments

@anveshmekala
Copy link
Contributor

Description

Currently, calcite-shell-panel has property position which is used to tweak the slotted calcite-action-bar placement. As part of the proposed refactor the property will be renamed to actionBarPosition since it is affecting the position of slotted calcite-action-bar only.

Proposed Advantages

Makes the property more meaningful and understandable.
Be consistent with existing pattern of {elementName}Position

Which Component

calcite-shell-panel

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@anveshmekala anveshmekala added refactor Issues tied to code that needs to be significantly reworked. breaking change Issues and pull requests with code changes that are not backwards compatible. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 30, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Nov 30, 2023
@anveshmekala anveshmekala added future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. and removed breaking change Issues and pull requests with code changes that are not backwards compatible. labels Dec 1, 2023
@anveshmekala
Copy link
Contributor Author

The prop will be deprecated first and removed in later milestones.

@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. design Issues that need design consultation prior to development. labels Aug 6, 2024
@geospatialem
Copy link
Member

Added a research spike and design to determine the best path forward for consistency and understandability for users, while also considering what should be supported and direction in the future.

@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Aug 6, 2024
@DitwanP DitwanP removed the needs triage Planning workflow - pending design/dev review. label Aug 8, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 8, 2024
@SkyeSeitz
Copy link

SkyeSeitz commented Aug 27, 2024 •
edited
Loading

Updated proposal:

Deprecate the position and layout props and set position by the Shell according to what slot the Shell Panel lives in.

panel-top position="start", layout="horizontal"
panel-bottom position="end", layout="horizontal"
panel-start position="start", layout="vertical"
panel-end position="end", layout="vertical"

@anveshmekala

@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Aug 27, 2024
@SkyeSeitz SkyeSeitz removed their assignment Aug 27, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 5 A few days of work, definitely requires updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
4 participants
@geospatialem @SkyeSeitz @DitwanP @anveshmekala