Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate background color variables for the calcite-dialog would be very helpful #8614

Closed
2 of 5 tasks
Tracked by #7180
jesseadamsnpgs opened this issue Jan 16, 2024 · 5 comments
Closed
2 of 5 tasks
Tracked by #7180
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive

Comments

@jesseadamsnpgs
Copy link

jesseadamsnpgs commented Jan 16, 2024

Check existing issues

Description

Currently the --calcite-modal-content-background variable works well for customizing the background color of the modal content, however, there isn't a clear way to customize only the modal header or footer background colors. The --calcite-ui-foreground-1 variable is used as the header background color, however, changing that variable results in also changing the header and footer background colors. It would be great if the header, content, and footer had separate CSS variables for more flexible targeted styling.

Acceptance Criteria

Separate background color override selectors, ie:

--calcite-modal-header-background
--calcite-modal-footer-background

Relevant Info

No response

Which Component

calcite-modal

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@jesseadamsnpgs jesseadamsnpgs added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 16, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. calcite-components-angular impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 16, 2024
@macandcheese macandcheese added the design-tokens Issues requiring design tokens. label Jan 16, 2024
@ellenupp
Copy link

Dashboards team is also interested in this.

We'll be introducing user-configurable "information windows" and would like more flexible styling options, specifically being able to target only the header background:

image

A separate CSS variable for the header would be great.

@geospatialem geospatialem added blocked This issue is blocked by another issue. and removed needs triage Planning workflow - pending design/dev review. labels Aug 13, 2024
@geospatialem geospatialem added this to the Stalled milestone Aug 13, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed blocked This issue is blocked by another issue. labels Aug 13, 2024
@geospatialem geospatialem removed this from the Stalled milestone Aug 13, 2024
@geospatialem
Copy link
Member

With the deprecation of the modal component, in favor of dialog - re-scoping the title of the request to dialog. Implementation timeline TBD after the initial token effort makes headway in #7180

@geospatialem geospatialem changed the title Separate background color variables for the calcite-modal would be very helpful Separate background color variables for the calcite-dialog would be very helpful Aug 13, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Nov 6, 2024
@macandcheese
Copy link
Contributor

This can leverage the tokens introduced here in Panel #10822

@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Dec 13, 2024
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 13, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 17, 2024
@geospatialem
Copy link
Member

Verified in 3.0.0-next.68 with the following tokens:

  • --calcite-dialog-background-color
  • --calcite-panel-header-background-color
  • --calcite-panel-footer-background-color
#my-custom-dialog {
  --calcite-dialog-background-color: var(--calcite-color-background);
  --calcite-action-background-color: var(--calcite-color-brand);
  --calcite-action-background-color-hover: var(--calcite-color-brand-hover);
  --calcite-action-background-color-pressed: var(--calcite-color-brand-pressed);
  --calcite-action-text-color: #000;
  --calcite-action-text-color-pressed: #000;
  --calcite-action-text-color-hover: #000;
  --calcite-panel-header-background-color: var(--calcite-color-brand);
  --calcite-panel-footer-background-color: var(--calcite-color-border-3);
}

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive
Projects
None yet
Development

No branches or pull requests

5 participants