Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmented control: should use border instead of outline for styling #8832

Open
1 of 5 tasks
Tracked by #7180
driskull opened this issue Feb 26, 2024 · 3 comments
Open
1 of 5 tasks
Tracked by #7180

Segmented control: should use border instead of outline for styling #8832

driskull opened this issue Feb 26, 2024 · 3 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-05-13 - 3.2....

Comments

@driskull
Copy link
Member

driskull commented Feb 26, 2024 •
edited
Loading

Description

styles should use border instead of outline for styling

Proposed Advantages

Using a border is the proper way to define borders

Which Component

segmented-control, segmented-control-item

Relevant Info

Feb-26-2024 14-41-51

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 26, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Feb 26, 2024
@driskull driskull changed the title Segmented control: styles should use border instead of oultine for styling the outline of the segmented control Segmented control: should use border instead of outline for styling Feb 26, 2024
@geospatialem geospatialem added design-tokens Issues requiring design tokens. design Issues that need design consultation prior to development. labels Aug 13, 2024
@geospatialem
Copy link
Member

geospatialem commented Aug 13, 2024 •
edited
Loading

Design expertise sought for resolution and implementation for consistency across the design system/components.

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Aug 13, 2024
@geospatialem geospatialem mentioned this issue Sep 3, 2024
Open
@ashetland
Copy link
Contributor

Agreed, if possible we should be using border.

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Oct 10, 2024
@github-actions github-actions bot added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added the estimate - 2 Small fix or update, may require updates to tests. label Oct 10, 2024
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-05-13 - 3.2.0 May Main Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @DitwanP @ashetland