Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8bit or 16 bit data collection #639

Closed
wants to merge 2 commits into from
Closed

Conversation

weaponwh
Copy link

Pull Request Details

Add RFNOC IP for 16 or 8 bit data collection support. record only

Description

add 16 or 8 bit data acquisition for x310/x300.
add VIO to flip bytes for little or big endian
8 bit data is truncated version of 16 bit. Haven't seen any DC bias during testing.
This design include all the files to build fpga bit files and ip driver

Related Issue

The design does not include user define acquisition software, see rfnoc_radio_loopback.cpp to implement user data acquisition software

Which devices/areas does this affect?

x300/x310

Testing Done

Tested on X300 with UHD version 4.0 UHD version 4.2 works but has warnings

Checklist

  • [x ] I have read the CONTRIBUTING document.
  • My code follows the code style of this project. See CODING.md.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, and all previous tests pass.
  • I have checked all compat numbers if they need updating (FPGA compat,
    MPM compat, noc_shell, specific RFNoC block, ...)

@weaponwh
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@weaponwh
Copy link
Author

recheck

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@weaponwh
@whan
whan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@weaponwh weaponwh closed this Oct 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
@weaponwh weaponwh reopened this Oct 20, 2022
@mbr0wn
Copy link
Contributor

mbr0wn commented Feb 16, 2024

@weaponwh Thanks for opening this, and sorry for not reacting sooner. We won't be merging this into UHD because the block implementation is too different from something we would like to support inside UHD. However, there is obvious benefit/utility to this. I suggest you make this an RFNoC out-of-tree module in your own github space.

Thanks again!

@mbr0wn mbr0wn closed this Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants