Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x3xx DAC interpolator value documentation #716

Closed
wants to merge 1 commit into from

Conversation

NIDvoez
Copy link
Contributor

@NIDvoez NIDvoez commented Jan 5, 2024

added 2 lines of comments to clarify that the DAC runs with an interpolation factor of 4

Pull Request Details

Due to a customer escalation we found out why we mention 800 MS/s on X3xx and 2974 Hardware Resources page. The DAC runs with an interpolation factor of 4 (200 MS/s * 4 = 800MS/s).

Description

Just 2 lines of code

Related Issue

none

Which devices/areas does this affect?

x3xx and 2974 documentation

Testing Done

none, since it is only documentation

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project. See CODING.md.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, and all previous tests pass.
  • I have checked all compat numbers if they need updating (FPGA compat,
    MPM compat, noc_shell, specific RFNoC block, ...)

added 2 lins of comments to clarify that the DAC runs with an interpolation factor of 4
Copy link

github-actions bot commented Jan 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NIDvoez
Copy link
Contributor Author

NIDvoez commented Jan 5, 2024

I have read the CLA Document and I hereby sign the CLA

@NIDvoez
Copy link
Contributor Author

NIDvoez commented Jan 5, 2024

recheck

@NIDvoez NIDvoez closed this Jan 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
@NIDvoez NIDvoez deleted the NIDvoez/X3xx_DAC_Interpolator_Doc branch January 5, 2024 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant