CMake improvements and compiler warning fixes

[nzqo]

Pull Request Details

I extracted these changes from my other MR that was closed just now (#679) without any changes to the examples. The original changes were made over a year ago and after rebasing a few of the fixes done there have already been committed in other MRs. What remains is rather little, so should hopefully pose no problems to merge

Description

Basically, after rebasing onto the current version of uhd, here's what these changes still entail:

• install_name wasnt manually set in CMake, which caused a warning in newer CMake versions due to breaking policy changes
• Version range in DPDK find package module wasnt handled properly. Fixed by simply adding HANDLE_VERSION_RANGE flag
• Substituted use of sprintf with safer and more idiomatic snprintf variant
• Included boost as System dependency. This effectively suppresses compiler warnings from included boost headers so one can focus on the uhd ones
• Fixed compiler warnings (unused variables and missing copy assignment)
• Some minor comment formatting improvements for readability.

Which devices/areas does this affect?

Minor changes to the build system and the host library.

Testing Done

Since this affects mainly the build system, testing was building and verifying that CMake and compiler warnings were fixed.

Checklist

• I have read the CONTRIBUTING document.
• My code follows the code style of this project. See CODING.md.
• I have updated the documentation accordingly.
• I have added tests to cover my changes, and all previous tests pass.
• I have checked all compat numbers if they need updating (FPGA compat,
  MPM compat, noc_shell, specific RFNoC block, ...)

[mbr0wn]

recheck

[nzqo]

recheck

rebased just now.

[mbr0wn]

recheck

rebased just now.

Sorry, that was for the CLA checker bot (I did some upgrades to fix that). You already signed the cla on #679, so you don't need to do that again, but I was hoping the CLA checker bot would automatically figure that out.

[mbr0wn]

Also, thanks for rebasing, and thanks for re-submitting this in the first place (after we had dealt with just the example portion of #679). We're finally in a good spot to review this and merge it. We might cherry-pick some changes and leave out others, though.

[mbr0wn]

Fixed compiler warnings (unused variables and missing copy assignment)

What's your compiler?

[nzqo]

If you enable trace logging, this will cause a compiler error.

Reintroduced. You are right, probably leftover from an older state.

What's your compiler?

Currently: AppleClang 16.0.0.16000026
I recompiled with that and strict CXX flags. Fixed a few more missing override specifiers and another CMake policy warning.

FYI: in mpm/python/setup.py.in, the tests_require keyword has been deprecated for a while (https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-tests-require). I'm not touching this here since I'm not sure about your python build process and to avoid dragging the MR out any longer :)

[mbr0wn]

I'm going to skip the policy change for now (we support an almost too wide range of CMake versions, and I also want to close this PR ASAP, and I don't want to spend time making sure we don't add a warning on some older CMake for now). Other than that, it's good to go. Should be another few days before it hits master, but thanks again!

[mbr0wn]

When you build this, what does uhd_config_info --dpdk-version print?

[mbr0wn]

I merged this without the changes to FindDPDK and the policy changes for now. It took a while to untangle issues with our internal CI pipelines (older CMake caused an impressive grind-to-halt on our DPDK tests). I think the HANDLE_VERSION_RANGE changes would be nice to add though so maybe I'll take that into our CI as well.

[mbr0wn]

This is declared "not recommended".

[mbr0wn]

What kind of warning do you see without HANDLE_VERSION_RANGE?