Added support for SQL Server 2017 #2
Conversation
|
Hi, first of all, thank you for your contribution. Nice to see this repo has value for you. I did expect a Dataset being added to the ReportItemTypes enum, but somehow this is not the case. I pulled the changes but can't build it. |
|
Sorry Peter, I didn’t have the time to reply before. I am not quite used to GIT and I may have done something wrong. I will verify when I have a moment.
I use SQL Server 2016 and VS 2019. Seems like my changes are working as I was able to use my modified version to pull the shared datasets from my RS. I will add some unit tests as well when again I have a moment to do so.
Thanks,
Skweda
From: Peter Bons <[email protected]>
Sent: September 3, 2019 4:09 AM
To: Expecho/ReportServer-Manager <[email protected]>
Cc: Skweda O'Bomsawin <[email protected]>; Author <[email protected]>
Subject: Re: [Expecho/ReportServer-Manager] Added support for shared DataSet (#2)
I did expect a Dataset being added to the ReportItemTypes enum, but somehow this is not the case. I pulled the changes but can't build it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2?email_source=notifications&email_token=ALUR6KK244NDW2N4UNYCUN3QHYLR3A5CNFSM4ISNISF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XMIWY#issuecomment-527352923>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALUR6KOICJ2HXXYIOKORZLLQHYLR3ANCNFSM4ISNISFQ>.
|
|
Sure, take your time. I've no doubt your changes are working but I do expect not all is included it the changeset to git. As you can see there are no changes in the file https://github.com/Expecho/ReportServer-Manager/blob/master/src/Logic/Shared/ReportItemTypes.cs which I would expect given there is a new ReportItemType. |
…wnloading multiple folders
|
Hi Peter, I have fix some issues and added support for SQL 2017 in my branch. I also changed the icon set to match SSRS 2016 style. Thanks. |
sobomsawin
changed the title
|
I kind of missed this last update. I'll take a look later this day! |
|
No worries, it took me a while to get back to it. I also groomed the unit tests and added one for the shared dataset. Now as a disclaimer, the lowest instance of SQL Server I have is 2014, so I cannot tell if my changes broke something in earlier versions. I will let you take a look and tell me if you see something wrong. Thanks |
Shared datasets were displayed, but right clicking on them would result in a crash. Added support of common right-click functionalities for DataSet report item.