diff --git a/.eslintrc.changed.js b/.eslintrc.changed.js index b2c9a46df078..ae82e38070e7 100644 --- a/.eslintrc.changed.js +++ b/.eslintrc.changed.js @@ -21,13 +21,7 @@ module.exports = { }, overrides: [ { - files: [ - 'src/libs/actions/IOU.ts', - 'src/libs/actions/Report.ts', - 'src/pages/workspace/WorkspaceInitialPage.tsx', - 'src/pages/home/report/PureReportActionItem.tsx', - 'src/libs/SidebarUtils.ts', - ], + files: ['src/pages/workspace/WorkspaceInitialPage.tsx', 'src/pages/home/report/PureReportActionItem.tsx', 'src/libs/SidebarUtils.ts'], rules: { 'rulesdir/no-default-id-values': 'off', }, diff --git a/.eslintrc.js b/.eslintrc.js index 61cb7621544d..aa98b7bdc464 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -3,7 +3,18 @@ const path = require('path'); const restrictedImportPaths = [ { name: 'react-native', - importNames: ['useWindowDimensions', 'StatusBar', 'TouchableOpacity', 'TouchableWithoutFeedback', 'TouchableNativeFeedback', 'TouchableHighlight', 'Pressable', 'Text', 'ScrollView'], + importNames: [ + 'useWindowDimensions', + 'StatusBar', + 'TouchableOpacity', + 'TouchableWithoutFeedback', + 'TouchableNativeFeedback', + 'TouchableHighlight', + 'Pressable', + 'Text', + 'ScrollView', + 'Animated', + ], message: [ '', "For 'useWindowDimensions', please use '@src/hooks/useWindowDimensions' instead.", @@ -11,6 +22,7 @@ const restrictedImportPaths = [ "For 'StatusBar', please use '@libs/StatusBar' instead.", "For 'Text', please use '@components/Text' instead.", "For 'ScrollView', please use '@components/ScrollView' instead.", + "For 'Animated', please use 'Animated' from 'react-native-reanimated' instead.", ].join('\n'), }, { @@ -138,6 +150,10 @@ module.exports = { { selector: ['variable', 'property'], format: ['camelCase', 'UPPER_CASE', 'PascalCase'], + filter: { + regex: '^private_[a-z][a-zA-Z0-9]+$', + match: false, + }, }, { selector: 'function', diff --git a/.github/ISSUE_TEMPLATE/TooltipsTemplate.md b/.github/ISSUE_TEMPLATE/TooltipsTemplate.md new file mode 100644 index 000000000000..882d88f6ccfb --- /dev/null +++ b/.github/ISSUE_TEMPLATE/TooltipsTemplate.md @@ -0,0 +1,28 @@ +--- +name: 'Tooltips Template' +about: Create this issue when adding a new tooltip to New Expensify +labels: Daily, Design, WaitingForCopy +title: 'Tooltips Template' +--- +Refer to https://stackoverflowteams.com/c/expensify/questions/20762 for the full process to add a tooltip. + +### Problem +Enter the problem that currently exists without the tooltip. + +### Solution +Enter the solution that implementing the tooltip will achieve. + +### What is the purpose of the tooltip? +Enter the purpose. + +### How should the tooltip look +Add the Figma Mock Up that Design builds. + +### Condition +We should show this tooltip to: + +### Decide the prioritisation + +Priority score: + +NOTE: Only one tooltip is shown at a time. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1446f1e4d851..2dfd9348d961 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -22,6 +22,13 @@ $ PROPOSAL: + + ### Tests